-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: sql support with SQLAlchemy - follow-up #6292
Comments
@jorisvandenbossche: Is there a minimum sqlalchemy version this is targeting? Edit: I see v0.8.1 (https://github.com/pydata/pandas/pull/5950/files#diff-f2202167afc438a107cf9f73ac4f9fb1R98). It may be helpful to know if it's a requirement / recommendation. If it's a larger project and the sqlalchemy version is locked and Pandas can be upgraded, they may still want to know if it's possible for them to utilize this at an older version. |
@tony this should work for pretty much all versions of SQLAlchemy; it uses mainly the connection features |
Hello, With the new sql interface, will the 'classic' DB2API still works with params of a sql being a dictionnary ? typical example = "execute('SELECT * FROM ATABLE WHERE AFIELD=%(x)s', {'x':x})" |
I added 'read and write a I (finally) have a need to use SQL so I'm going to be using sqlalchemy and the new pandas sql stuff pretty extensively in the next few weeks. I'll report what I find. Doing a |
@TomAugspurger Super! Certainly report (and fix? :-) everything, bugs, annoyances, suggestions. There are still a lot of issue to report and fix. @stonebig I think so. Would you be able to test it with? |
if you can move residual issues that are not likely to be closed in 0.14 to 0.14.1 (or later) release notes / v0.14.0.txt needed as well not pushing, but lmk when you think you are 'ready' enough on this |
@jreback I will try to finish some things of this thursday of friday. Is that OK? |
sure thxs |
#5950 is now merged! (Thanks to @mangecoeur)
But there were still some issue to flesh out/fix:
functional api (read_table/read_sql)(fixed in API: update SQL functional api (GH6300) #6867)other public functions? (execute, has_table)`(see API: user api for new sql functionality #6300 and SQL: bunch of fixes based on the old tests #6987)MySQL was taken out of the 2.7 build, for some reason was failing the build process: 043d165, and failure here (see install.sh): https://travis-ci.org/jreback/pandas/jobs/18477137 (note Joris: I think this is OK now with pymysql)
OperationsError
(e.g. have PyMySQL installed but server is not running) -> TST: skip sql tests if connection to server fails #6651columns
argument inread_table
not workingitertuples
rather thaniterrows
BUG: SQL writing can lead to data loss #6509MultiIndex
(soindex_col
should take a list as well as a scalar) (fixed in ENH: SQL multiindex support #6735)There is also a todo list in #4163, but I thought it is cleaner to start a new one (but maybe we should copy some over).
Complement the list if you think of others!
The text was updated successfully, but these errors were encountered: