Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: use sqlalchemy 0.7.1 in 2.6 build (GH6340) #7022

Merged
merged 1 commit into from
Jun 14, 2014

Conversation

jreback
Copy link
Contributor

@jreback jreback commented May 1, 2014

closes #6340

@jreback jreback added the SQL label May 1, 2014
@jreback jreback added this to the 0.14.0 milestone May 1, 2014
@jreback
Copy link
Contributor Author

jreback commented May 1, 2014

@jorisvandenbossche

ok.....good thing we tested!

this is 0.7.1 for sqlalchemy, and slightly older versions of pymsql and psycopg2

https://travis-ci.org/jreback/pandas/jobs/24212656

@jorisvandenbossche
Copy link
Member

strange, the integer columns fail. We convert it to a string (https://github.com/pydata/pandas/blob/master/pandas/io/sql.py#L586), but for some reason sqlalchemy converts it back to an int. Have to investigate.

@jreback
Copy link
Contributor Author

jreback commented May 1, 2014

ok...my pr is up their...lmk when you want to merge (or you can simply take and rebase on fix ontop)
up 2 you

also ok with simply skipping that test on a too old version of sqlalchemy (seeing as its the only 1 that failed).

@jorisvandenbossche
Copy link
Member

But possibly also a bug on our side (as here https://github.com/pydata/pandas/blob/master/pandas/io/sql.py#L520 we don't convert the column names to strings when constructing the dict which is passed to execute). Will look at it later.

In any case, say it is only this that is not working for sqlalchemy 0.7. Do we say they need 0.8, or just say 0.7 is possible but that does not work? Can we eg skip that one test when using sqlalchemy 0.7?

@jreback
Copy link
Contributor Author

jreback commented May 1, 2014

I would just say min in 0.7.1 and leave it at that

then skip this test and/or fix. good enough (in 0.14.1 can extend the testing if you'd like)

@jreback
Copy link
Contributor Author

jreback commented May 5, 2014

@jorisvandenbossche you are going to cover the build change in another PR, yes? or want me to keep this open

@jreback jreback added the CI label May 5, 2014
@jreback jreback modified the milestones: 0.14.1, 0.14.0 May 14, 2014
@jreback
Copy link
Contributor Author

jreback commented May 14, 2014

bumping this; for 0.14.1 can work this in (and test with MySqlDB as well), https://pypi.python.org/pypi/MySQL-python/1.2.5

@jorisvandenbossche
Copy link
Member

@jreback Can you rebase this? Normally tests should now pass after #7456

@jreback jreback modified the milestones: 0.14.1, 0.15.0 Jun 14, 2014
jreback added a commit that referenced this pull request Jun 14, 2014
BLD: use sqlalchemy 0.7.1 in 2.6 build (GH6340)
@jreback jreback merged commit 59559ea into pandas-dev:master Jun 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLD: test with an older version of sql alchemy
2 participants