ERR/API: Raise NotImplementedError when method is not implemented (issue: 7692) #11095
Conversation
|
@jreback Does this need a whatsnew note or test? Would the test to check whether this raises |
|
tests |
|
@jreback thanks could you check the update again? |
| p = Panel(np.arange(3*4*5).reshape(3,4,5), items=['ItemA','ItemB','ItemC'], \ | ||
| major_axis=pd.date_range('20130101',periods=4),minor_axis=list('ABCDE')) | ||
| d = p.sum(axis=1).ix[0] | ||
| with self.assertRaises(NotImplementedError): |
There was a problem hiding this comment.
let's exercise this with all of the ops for now e.g .add/.sub etc
|
Thanks. Done @jreback |
|
On green. Could you merge? @jreback |
|
@terrytangyuan just a single ping is enough. |
| d = p.sum(axis=1).ix[0] | ||
| with self.assertRaises(NotImplementedError): | ||
| p.mul(d, axis=0) | ||
| with self.assertRaises(NotImplementedError): |
There was a problem hiding this comment.
make a loop of all of the ops functions (hint, there are more)
|
@jreback I apologize for the repetitive ping and thanks for the feedback. I've made the changes. |
| @@ -679,6 +679,8 @@ def _combine(self, other, func, axis=0): | |||
| return self._combine_frame(other, func, axis=axis) | |||
| elif np.isscalar(other): | |||
| return self._combine_const(other, func) | |||
| else: | |||
| raise NotImplementedError | |||
There was a problem hiding this comment.
give a meaningful message here
|
pls add a whatsnew note (Bug fixes) for 0.17.0 |
jreback
added
Error Reporting
|
@jreback Done. On green now. Thanks. |
| @@ -1100,7 +1100,7 @@ Bug Fixes | |||
| - Bug causes memory leak in time-series line and area plot (:issue:`9003`) | |||
|
|
|||
| - Bug when setting a ``Panel`` sliced along the major or minor axes when the right-hand side is a ``DataFrame`` (:issue:`11014`) | |||
|
|
|||
| - Bug that does not raise `NotImplementedError` when method is not implemented (:issue:`7692`) | |||
There was a problem hiding this comment.
not obvious what the change is
|
Thanks for the review @jreback . Fixed and on green now. |
| @@ -679,6 +679,8 @@ def _combine(self, other, func, axis=0): | |||
| return self._combine_frame(other, func, axis=axis) | |||
| elif np.isscalar(other): | |||
| return self._combine_const(other, func) | |||
| else: | |||
| raise NotImplementedError('This method has not been implemented yet. ') | |||
There was a problem hiding this comment.
needs an intelligeble message here.
There was a problem hiding this comment.
What do you mean by that?
There was a problem hiding this comment.
well, its already raising NotImplementedError, so would be nice to know why
There was a problem hiding this comment.
@jreback How about [op-method-name] has not been implemented in Panel class yet. Please wait for the next release?
There was a problem hiding this comment.
no, just say this type has not been implemented.
There was a problem hiding this comment.
@jreback any idea on how to access the op-method-name that's not implemented?
func returns <function na_op at 0x10358dde8> and func.__name__ returns na_op. Neither of these is something I expected, e.g. add, mul, etc. What is na_op BTW?
There was a problem hiding this comment.
just say that this type(other) is not supported (eg. print that could, in this case it would be Series
| @@ -679,6 +679,8 @@ def _combine(self, other, func, axis=0): | |||
| return self._combine_frame(other, func, axis=axis) | |||
| elif np.isscalar(other): | |||
| return self._combine_const(other, func) | |||
| else: | |||
| raise NotImplementedError(str(type(other))+ ' is not supported. ') | |||
There was a problem hiding this comment.
say in combine operations with type(self)
…t implemented (issue: 7692) (+1 squashed commit) Squashed commits: [9c56cd0] ERR/API: Raise NotImplementedError when Panel operator function is not implemented (issue: 7692) (+1 squashed commit) Squashed commits: [6c036e5] ERR/API: Raise NotImplementedError when Panel operator function is not implemented (issue: 7692) (+1 squashed commit) Squashed commits: [1e8ff32] ERR/API: Raise NotImplementedError when Panel operator function is not implemented (issue: 7692) (+1 squashed commit) Squashed commits: [7b487c7] ERR/API: Raise NotImplementedError when Panel operator function is not implemented (issue: 7692) (+1 squashed commit) Squashed commits: [9e7aa80] ERR/API: Raise NotImplementedError when method is not implemented (issue: 7692) (+1 squashed commit) Squashed commits: [17fadd1] ERR/API: Raise NotImplementedError when method is not implemented (issue: 7692) (+1 squashed commit) Squashed commits: [4b149df] ERR/API: Raise NotImplementedError when method is not implemented in Panel.py (issue: 7692) (+1 squashed commit) Squashed commits: [8832b74] ERR/API: Raise NotImplementedError when method is not implemented (issue: 7692) (+1 squashed commit) Squashed commits: [fc01bf8] ERR/API: Raise NotImplementedError when method is not implemented (issue: 7692) (+1 squashed commit) Squashed commits: [a04c4a2] raise error when not implemented
|
merged via 597aa42 thanks! |
Fixed #7692