TST: allow assert_almost_equal to handle pandas instances #12247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +32,8 @@ def test_rank_tie_methods(self): | |||
|
|
|||
| def _check(s, expected, method='average'): | |||
| result = s.rank(method=method) | |||
| assert_almost_equal(result, expected) | |||
| print(result) | |||
| tm.assert_series_equal(result, Series(expected)) | |||
sinhrks
force-pushed
the
assert_almost
branch
from
b30a899 to
bb3c93a
Compare
| def check_comparators(series, other, check_dtype=True): | ||
| _check_op(series, other, operator.gt, check_dtype=check_dtype) | ||
| _check_op(series, other, operator.ge, check_dtype=check_dtype) | ||
| _check_op(series, other, operator.eq, check_dtype=check_dtype) |
There was a problem hiding this comment.
were these just not being checked before?
|
just a small question |
sinhrks
force-pushed
the
assert_almost
branch
from
bb3c93a to
dbf4cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11584.
Because many existing tests expects
assert_almost_equalto comparepandasinstances, it looks better to call appropriate test functions rather than raise.I've also fixed some failure cases caused by the change (comparing
Seriesandlist, etc).