do not upcast results to float64 when float32 scalar *+/- float64 array #12559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -918,6 +918,9 @@ assignments are valid for multi-line expressions. | |||
| g = f / 2.0""", inplace=True) | |||
| df | |||
|
|
|||
| ``eval``'s upcasting rules for float32 types have also been updated to be more | |||
jreback
added
Dtype Conversions
|
can you rebase / update & move whatsnew to 0.18.2 |
|
can you rebase / update? |
|
yes, I will try to find some time over the weekend to do this. |
Current coverage is 84.22%@@ master #12559 diff @@
==========================================
Files 138 138
Lines 50667 50680 +13
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42672 42683 +11
- Misses 7995 7997 +2
Partials 0 0
|
|
@jreback green |
|
actually, let me see if I can increase the code coverage |
| @@ -89,6 +89,9 @@ Other enhancements | |||
|
|
|||
| - ``pd.read_html()`` has gained support for the ``decimal`` option (:issue:`12907`) | |||
|
|
|||
| - ``eval``'s upcasting rules for float32 types have also been updated to be more | |||
There was a problem hiding this comment.
double-backticks around float32 (and float64)
no space after the colon (:issue:12388)
|
looks good. some style points. ping when change / green. |
|
@jreback green |
|
thanks @jennolsen84 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff