Fix to_gbq method when verbose=False #13244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self._print("\rStreaming Insert is {0}% Complete".format( | ||
| ((total_rows - remaining_rows) * 100) / total_rows)) | ||
| if self.verbose: | ||
| self._print("\rStreaming Insert is {0}% Complete".format( |
There was a problem hiding this comment.
self._print already checks for self.verbose how does this help?
There was a problem hiding this comment.
total_rows is assigned after a check for verbose at line 430, so presently this fails because it can't evaluate the unassigned variable. If self._print is already checking for verbose, perhaps removing the conditional at line 429 and always assigning total_rows is the better move?
There was a problem hiding this comment.
oh u mean it's None
yes it should be valid (can even be -1) or whatever
|
@cgrin an you update |
|
@jreback I can't test this, but I suppose this is good to merge? (I restarted the tests, was only a failing test related to Yahoo/Google datareader) |
|
I don't merge these until someone posts a local run |
|
but this does look trivial |
|
@parthea Would you be able to test this? |
Current coverage is 87.82% (diff: 0.00%)@@ master #13244 diff @@
==========================================
Files 138 143 +5
Lines 51126 71578 +20452
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43122 62866 +19744
- Misses 8004 8712 +708
Partials 0 0
|
|
All gbq tests passed locally |
|
@parthea thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
to_gbqmethod fails whenverbose=False, as the printing of progress is done regardless of the value of theverboseflag, and thereforetotal_rowsgets called without being set. This change suppresses printing of progress whenverbose=False.