CLN: Remove the engine parameter in CSVFormatter and to_csv #13419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,8 @@ Other enhancements | |||
| Backwards incompatible API changes | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| - ``DataFrame.to_csv()`` has dropped the ``engine`` parameter (:issue:`13419`) | |||
There was a problem hiding this comment.
Can you move this to "Removal of prior version deprecations/changes" (a bit below)
jorisvandenbossche
added
IO CSV
gfyoung
force-pushed
the
to-csv-engine-param-remove
branch
from
2677cc2
to
b03e148
Compare
| @@ -64,6 +64,7 @@ Deprecations | |||
| Removal of prior version deprecations/changes | |||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| - ``DataFrame.to_csv()`` has dropped the ``engine`` parameter (:issue:`13419`) | |||
There was a problem hiding this comment.
put the original issue number here (you can leave this one as well if you want).
1 task
|
see #11274 this was actually just deprecated in 0.17.1 (even though it said 0.13). |
gfyoung
force-pushed
the
to-csv-engine-param-remove
branch
6 times, most recently
from
5b0851c
to
36e4f42
Compare
gfyoung
force-pushed
the
to-csv-engine-param-remove
branch
11 times, most recently
from
3743721
to
489f2c0
Compare
gfyoung
force-pushed
the
to-csv-engine-param-remove
branch
5 times, most recently
from
1508d9c
to
7bd4856
Compare
gfyoung
force-pushed
the
to-csv-engine-param-remove
branch
7 times, most recently
from
de7c13b
to
16a3264
Compare
|
@gfyoung Master is now targeted for 0.19.0, so this can go in. Can you move the whatsnew note to the correct file? |
gfyoung
force-pushed
the
to-csv-engine-param-remove
branch
from
16a3264
to
ab0fa11
Compare
Current coverage is 84.32%@@ master #13419 diff @@
==========================================
Files 138 138
Lines 51157 51083 -74
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43131 43076 -55
+ Misses 8026 8007 -19
Partials 0 0
|
|
@jreback , @jorisvandenbossche : Travis is passing, so ready to merge if there are no other concerns. |
gfyoung
force-pushed
the
to-csv-engine-param-remove
branch
from
ab0fa11
to
ddd6cd2
Compare
|
lgtm. ping on green. |
|
@jreback : Travis is giving the green light. Ready to merge if there are no other concerns. |
|
@gfyoung yes, merging shortly. |
|
thanks @gfyoung |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory.
Internal code and #6581 indicate that this was long overdue.