BUG: Handle infinite values correctly in Series.argmax #13625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 11, 2016 18:50
matthewwillian
changed the title
| @@ -1290,3 +1290,4 @@ Bug Fixes | |||
| - Bug when specifying a UTC ``DatetimeIndex`` by setting ``utc=True`` in ``.to_datetime`` (:issue:`11934`) | |||
| - Bug when increasing the buffer size of CSV reader in ``read_csv`` (:issue:`12494`) | |||
| - Bug when setting columns of a ``DataFrame`` with duplicate column names (:issue:`12344`) | |||
| - Bug when calling Series.argmax with infinite values (:issue: `13595`) | |||
sinhrks
added
Bug
Numeric Operations
| @@ -549,3 +549,5 @@ Bug Fixes | |||
| - Bug in ``groupby`` with ``as_index=False`` returns all NaN's when grouping on multiple columns including a categorical one (:issue:`13204`) | |||
|
|
|||
| - Bug where ``pd.read_gbq()`` could throw ``ImportError: No module named discovery`` as a result of a naming conflict with another python package called apiclient (:issue:`13454`) | |||
|
|
|||
| - Bug when calling Series.argmax with infinite values (:issue: `13595`) | |||
There was a problem hiding this comment.
use double-back ticks around Series.argmax
no space after ``:issue:13595)
|
@matthewwillian You have some PEP8 issues (see the travis log at the bottom: https://travis-ci.org/pydata/pandas/jobs/144182270), and a failing test. |
|
Okay, thank you. I will take a look. |
|
@matthewwillian Can you update/rebase? |
|
It's great if you can include the fix for |
|
can you rebase |
|
can you rebase / update? |
|
can you rebase and move release notes to 0.19.2 |
|
can you rebase / update |
|
closing, but if you want to update, pls comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff