CLN: Removed outtype in DataFrame.to_dict #13627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
df-to-dict-outtype-remove
branch
from
6e398b6 to
1b5099d
Compare
| @@ -443,6 +443,7 @@ Removal of prior version deprecations/changes | |||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| - ``DataFrame.to_csv()`` has dropped the ``engine`` parameter, as was deprecated in 0.17.1 (:issue:`11274`, :issue:`13419`) | |||
| - ``DataFrame.to_dict()`` has dropped the ``outtype`` parameter in favor of ``orient`` (:issue:``) | |||
There was a problem hiding this comment.
put this issue number then
There was a problem hiding this comment.
and the issue you reference in the issue
1 task
Current coverage is 84.33%@@ master #13627 diff @@
==========================================
Files 138 138
Lines 51100 51099 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43097 43096 -1
Misses 8003 8003
Partials 0 0
|
gfyoung
force-pushed
the
df-to-dict-outtype-remove
branch
from
1b5099d to
a7afe55
Compare
|
@jreback : Made the requested doc change (no tests need as a result hence the |
|
@gfyoung Thanks! |
nateGeorge
pushed a commit
to nateGeorge/pandas
that referenced
this pull request
Aug 15, 2016
Follows up from pandas-dev#8486 in 0.15.0 by removing outtype in DataFrame.to_dict()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up from #8486 in
0.15.0by removingouttypeinDataFrame.to_dict()Fortunately or unfortunately, no tests were written then to test the deprecation, so there was nothing to remove from the test suite this time around.