ENH: Add support for writing variable labels to Stata files #13631

bashtage · 2016-07-12T17:41:50Z

closes ENH: Support Stata variable labels #13536
closes Document pandas.DataFrame.to_stata data_label #13535
tests added / passed
passes git diff upstream/master | flake8 --diff
whatsnew entry

Add support for writing variable labels
Fix documentation for to_stata
Clean up function name to improve readability

TomAugspurger · 2016-07-12T21:33:52Z

pandas/core/frame.py

+            case the current time is used.
+        dataset_label : str
+            A label for the data set.  Should be 80 characters or smaller.
+        variable_labels : dict


Maybe add a note here about the variables needing to be latin-1 encodable? Also perhaps note that a ValueError is raised if not, or if any label is too long.

TomAugspurger · 2016-07-12T21:35:19Z

Just the one minor note, plus a whatsnew entry (this can go in 0.19). Other than that this looks great assuming Travis passes.

bashtage · 2016-07-12T21:44:08Z

It will fail on Python 2.7 I can see now. But should be easy enough to fix.

codecov-io · 2016-07-12T22:18:59Z

Current coverage is 84.38%

Merging #13631 into master will increase coverage by <.01%

@@             master     #13631   diff @@
==========================================
  Files           142        142          
  Lines         51223      51235    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43223      43235    +12   
  Misses         8000       8000          
  Partials          0          0

Powered by Codecov. Last updated by d7c028d...1e1e1bf

jreback · 2016-07-13T10:22:51Z

pandas/io/tests/test_stata.py

@@ -1113,6 +1113,56 @@ def test_read_chunks_columns(self):
                tm.assert_frame_equal(from_frame, chunk, check_dtype=False)
                pos += chunksize

+    def test_write_variable_labels(self):
+        original = pd.DataFrame({'a': [1, 2, 3, 4],


add issue number

jreback · 2016-07-13T10:35:36Z

is this forward compat? IOW, righting the labels should then be readable by older versions of pandas?

jreback · 2016-07-13T10:36:18Z

pandas/core/frame.py

+        variable_labels : dict
+            Dictionary containing columns as keys and variable labels as
+            values. Each label must be 80 characters or smaller. Raises a
+            ValueError if a label is too long or contains characters that


add versionadded tag

bashtage · 2016-07-14T11:54:07Z

is this forward compat? IOW, righting the labels should then be readable by older versions of pandas?

Should be -- the reader code always has to read these labels even if it doesn't do anything with them. One can read them using StataReader but not sure when the method to read the labels was added.

bashtage · 2016-07-14T12:48:51Z

@TomAugspurger @jreback Sort of unrelated issue, but do have any idea why my Travis fails when running pandas test suite? My travis always fails even when the pull request into pandas pydata travis works fine.

Most recent example:

https://travis-ci.org/bashtage/pandas/builds/144722347

I see lots of errors like:

======================================================================
ERROR: pandas.io.tests.test_pickle.TestPickle.test_pickles('0.18.1',)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/pandas/lib/python3.5/site-packages/nose/case.py", line 382, in setUp
    try_run(self.inst, ('setup', 'setUp'))
  File "/home/travis/miniconda/envs/pandas/lib/python3.5/site-packages/nose/util.py", line 471, in try_run
    return func()
  File "/home/travis/build/bashtage/pandas/pandas/io/tests/test_pickle.py", line 38, in setUp
    self.data = create_pickle_data()
  File "/home/travis/build/bashtage/pandas/pandas/io/tests/generate_legacy_storage_files.py", line 168, in create_pickle_data
    if _loose_version < '0.14.1':
  File "/home/travis/miniconda/envs/pandas/lib/python3.5/distutils/version.py", line 52, in __lt__
    c = self._cmp(other)
  File "/home/travis/miniconda/envs/pandas/lib/python3.5/distutils/version.py", line 337, in _cmp
    if self.version < other.version:
TypeError: unorderable types: str() < int()

jreback · 2016-07-14T13:06:00Z

@bashtage you have an older fork; git does not update tags with a fork (not really sure why this doesn't go along with cloning but it doesnt').

so

git push tags yourbranch master --tags

will push them up to your fork of master, so future branches should be ok
you can also do this on your current branch.

there is a setup section that shows the gittags (after you update then this will show them)

bashtage · 2016-07-14T22:38:13Z

@jreback All green.

jreback · 2016-07-14T23:50:01Z

pandas/core/frame.py

        encoding : str
            Default is latin-1. Note that Stata does not support unicode.
        byteorder : str
            Can be ">", "<", "little", or "big". The default is None which uses
            `sys.byteorder`
+        time_stamp : datetime


where these new entries just left out before?

Yes. Arguments were present but uncodumented. Mentioned in one fo the issues this closes.

jreback · 2016-07-14T23:53:09Z

just some formatting changes. can you add a whatsnew entry as well. doc updates if you think are needed as well. ping on green.

Add support for writing variable labels Fix documentation for to_stata Clean up function name to improve readability closes pandas-dev#13536 closes pandas-dev#13535

bashtage · 2016-07-15T14:33:28Z

@jreback Should be ready

jreback · 2016-07-19T02:00:46Z

thanks @bashtage

bashtage force-pushed the stata-data-labels branch from b25d26c to e7a1e62 Compare July 12, 2016 17:45

TomAugspurger reviewed Jul 12, 2016
View reviewed changes

TomAugspurger added Enhancement IO Stata read_stata, to_stata labels Jul 12, 2016

TomAugspurger added this to the 0.19.0 milestone Jul 12, 2016

bashtage force-pushed the stata-data-labels branch from e7a1e62 to 3ef8342 Compare July 12, 2016 22:11

bashtage force-pushed the stata-data-labels branch from 3ef8342 to d4334f4 Compare July 13, 2016 06:03

jreback reviewed Jul 13, 2016
View reviewed changes

bashtage force-pushed the stata-data-labels branch from d4334f4 to a93be07 Compare July 14, 2016 12:11

bashtage force-pushed the stata-data-labels branch from a93be07 to c33c670 Compare July 14, 2016 16:49

bashtage changed the title ~~ENH: Add support for writing variable labels~~ ENH: Add support for writing variable labels to Stata files Jul 14, 2016

jreback reviewed Jul 14, 2016
View reviewed changes

bashtage force-pushed the stata-data-labels branch from c33c670 to 4706e6d Compare July 15, 2016 11:34

ENH: Add support for writing variable labels

1e1e1bf

Add support for writing variable labels Fix documentation for to_stata Clean up function name to improve readability closes pandas-dev#13536 closes pandas-dev#13535

bashtage force-pushed the stata-data-labels branch from 4706e6d to 1e1e1bf Compare July 15, 2016 11:37

jreback closed this in fafef5d Jul 19, 2016

bashtage deleted the stata-data-labels branch January 24, 2017 21:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH: Add support for writing variable labels to Stata files #13631

ENH: Add support for writing variable labels to Stata files #13631

bashtage commented Jul 12, 2016 •

edited

Loading

TomAugspurger Jul 12, 2016

TomAugspurger commented Jul 12, 2016

bashtage commented Jul 12, 2016

codecov-io commented Jul 12, 2016 •

edited

Loading

jreback Jul 13, 2016

jreback commented Jul 13, 2016

jreback Jul 13, 2016

bashtage commented Jul 14, 2016

bashtage commented Jul 14, 2016

jreback commented Jul 14, 2016

bashtage commented Jul 14, 2016

jreback Jul 14, 2016

bashtage Jul 15, 2016

jreback commented Jul 14, 2016 •

edited

Loading

bashtage commented Jul 15, 2016

jreback commented Jul 19, 2016

ENH: Add support for writing variable labels to Stata files #13631

ENH: Add support for writing variable labels to Stata files #13631

Conversation

bashtage commented Jul 12, 2016 • edited Loading

TomAugspurger Jul 12, 2016

Choose a reason for hiding this comment

TomAugspurger commented Jul 12, 2016

bashtage commented Jul 12, 2016

codecov-io commented Jul 12, 2016 • edited Loading

Current coverage is 84.38%

jreback Jul 13, 2016

Choose a reason for hiding this comment

jreback commented Jul 13, 2016

jreback Jul 13, 2016

Choose a reason for hiding this comment

bashtage commented Jul 14, 2016

bashtage commented Jul 14, 2016

jreback commented Jul 14, 2016

bashtage commented Jul 14, 2016

jreback Jul 14, 2016

Choose a reason for hiding this comment

bashtage Jul 15, 2016

Choose a reason for hiding this comment

jreback commented Jul 14, 2016 • edited Loading

bashtage commented Jul 15, 2016

jreback commented Jul 19, 2016

bashtage commented Jul 12, 2016 •

edited

Loading

codecov-io commented Jul 12, 2016 •

edited

Loading

jreback commented Jul 14, 2016 •

edited

Loading