-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Make pandasSQL_builder private #13668
MAINT: Make pandasSQL_builder private #13668
Conversation
Current coverage is 84.38%@@ master #13668 diff @@
==========================================
Files 142 142
Lines 51223 51223
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43223 43223
Misses 8000 8000
Partials 0 0
|
@sinhrks , @jorisvandenbossche , @jreback : any updates on this? Seems relatively trivial to merge. |
lgtm. @jorisvandenbossche |
Sorry for the delay. |
@jorisvandenbossche : Ah, that's a good point. If the intention was internal, but people are actually using this function for their own |
Yep, then we just let it be :-) |
Sorry for my inclarity triggering you to action |
No worries. Good that we at least investigated. |
Per discussion with @jorisvandenbossche here.