DEPR: Panel4d and panelND #13776
DEPR: Panel4d and panelND #13776
Conversation
|
This is was a PITA (because some things produce warnings in PY2 but not in PY3) :< |
|
@shoyer @MaximilianR esp have a look at the warnings (e.g. maybe have a specific page)? |
|
Can we add the deprecation notice to the docstrings for @MaximilianR Let's see if we can finish up that doc page on xarray for panel users (pydata/xarray#832) -- it would be great to be able to link to that in the pandas docs. |
| @@ -37,6 +38,9 @@ | |||
| def panel4d_init(self, data=None, labels=None, items=None, major_axis=None, | |||
| minor_axis=None, copy=False, dtype=None): | |||
|
|
|||
| # deprecation GH13564 | |||
| warnings.warn("Panel4D is deprecated and will be removed in a " | |||
| "future version", FutureWarning, stacklevel=2) | |||
There was a problem hiding this comment.
Maybe refer to xarray here as well? (like in the docs)
|
Oh boy, that will be a joy if when we can remove it :-) |
|
I wish - the problem is that FutureWarninh is generic so No easy way |
|
Can't you filter with a regex on the message or module? |
|
I gave it a try - u r welcome to change it - it's buggy in 27 I think |
|
For the next big depr then :-) |
Current coverage is 85.32% (diff: 100%)
|
I'll have a go this week! |
|
@jorisvandenbossche updated. @shoyer |
| @@ -58,11 +58,10 @@ class TestPDApi(Base, tm.TestCase): | |||
|
|
|||
| # these are already deprecated; awaiting removal | |||
| deprecated_classes = ['SparsePanel', 'TimeSeries', 'WidePanel', | |||
| 'SparseTimeSeries'] | |||
| 'SparseTimeSeries', 'Panel', 'Panel4D'] | |||
There was a problem hiding this comment.
I don't think Panel is already deprecated?
|
Small comment/question, for the rest ready to merge for me. The doc link can indeed be updated later. |
closes #13564