BUG: Avoid sentinel-infinity comparison problems (#13445) #14006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.28% (diff: 100%)@@ master #14006 diff @@
==========================================
Files 139 139
Lines 50229 50229
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42837 42838 +1
+ Misses 7392 7391 -1
Partials 0 0
|
jreback
added
Bug
Algos
|
thanks @dsm054 always nice to see PR's from you! keep em coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem causing #13445 ultimately traces to the fact that our Infinity/NegInfinity objects were greater than/less than themselves, which violates an assumption numpy makes when sorting. This was separately reported as numpy/numpy#7934, but we can fix and test downstream as well.
git diff upstream/master | flake8 --diff