CLN: Removed DataFrame.to_wide #14039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
to-wide-remove
branch
from
25ec40f to
b9a63b2
Compare
Current coverage is 85.25% (diff: 100%)@@ master #14039 diff @@
==========================================
Files 139 139
Lines 50380 50379 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 42953 42952 -1
Misses 7427 7427
Partials 0 0
|
gfyoung
force-pushed
the
to-wide-remove
branch
from
b9a63b2 to
b30a420
Compare
| @@ -78,8 +78,7 @@ | |||
| OrderedDict, raise_with_traceback) | |||
| from pandas import compat | |||
| from pandas.compat.numpy import function as nv | |||
| from pandas.util.decorators import (deprecate, Appender, Substitution, | |||
| deprecate_kwarg) | |||
| from pandas.util.decorators import deprecate, Appender, Substitution | |||
There was a problem hiding this comment.
It's deprecate that should be removed, not deprecate_kwarg
(hence the travis failures)
gfyoung
force-pushed
the
to-wide-remove
branch
from
b30a420 to
7879d54
Compare
| @@ -894,6 +894,7 @@ Removal of prior version deprecations/changes | |||
| - ``Panel.shift()`` has dropped the ``lags`` parameter in favour of ``periods`` (:issue:`14041`) | |||
| - ``pd.Index`` has dropped the ``diff`` method in favour of ``difference`` (:issue:`13669`) | |||
|
|
|||
| - ``pd.DataFrame`` has dropped the ``to_wide`` method in favour of ``to_panel`` (:issue:`14039`) | |||
There was a problem hiding this comment.
can you audit the favour -> favor (or just pick one) for all of these lines. I know trivial.......
|
lgtm. ping on green. |
|
Let's leave that for another PR :-) (I/we will do a full read through of the whatsnew file anyway) |
|
@gfyoung Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_widewas deprecated since 2011 (1134c9f)xref #13777
No tests for this deprecation beforehand to remove 😞