Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] set_axis now has inplace=False #14656

Closed
wants to merge 1 commit into from
Closed

[WIP] set_axis now has inplace=False #14656

wants to merge 1 commit into from

Conversation

den-run-ai
Copy link

@den-run-ai den-run-ai commented Nov 14, 2016 •
edited by jreback
Loading

@den-run-ai
Copy link
Author

#14636

@codecov-io
Copy link

Current coverage is 85.28% (diff: 50.00%)

Merging #14656 into master will decrease coverage by <.01%

@@             master     #14656   diff @@
==========================================
  Files           140        140          
  Lines         50693      50697     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43234      43235     +1   
- Misses         7459       7462     +3   
  Partials          0          0

Powered by Codecov. Last update 1d6dbb4...c10a2f4

@jreback
Copy link
Contributor

jreback commented Nov 14, 2016

needs tests and lint fixing (which will now show up after you rebase)

@jreback jreback added API Design Indexing Related to indexing on series/frames, not to indexes themselves Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 14, 2016
@jreback
Copy link
Contributor

jreback commented Dec 21, 2016

@denfromufa can you add tests?

@jreback
Copy link
Contributor

jreback commented Feb 1, 2017

closing as stale

@jreback jreback closed this Feb 1, 2017
@toobaz toobaz mentioned this pull request Jul 17, 2017
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API Design Indexing Related to indexing on series/frames, not to indexes themselves Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: set_axis does not have inplace=False
3 participants
@den-run-ai @codecov-io @jreback