API: allow list-like to DataFrame rename #15029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 1, 2017
| assert_frame_equal(result, expected) | ||
|
|
||
| result = df.copy() | ||
| result.rename(columns=['J', 'K'], index=['a', 'b'], inplace=True) |
There was a problem hiding this comment.
test with ndarray and with an Index
a scalar should error yes?
Current coverage is 84.77% (diff: 100%)@@ master #15029 diff @@
==========================================
Files 145 145
Lines 51131 51133 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43345 43348 +3
+ Misses 7786 7785 -1
Partials 0 0
|
|
this is also now an alternative to the |
|
I added a couple doc references, but I might be missing something - wasn't sure if there is a canonical spot for the |
|
http://pandas.pydata.org/pandas-docs/stable/indexing.html#set-reset-index ad-hoc indexing. This would be expanded in any event (and maybe moved to http://pandas.pydata.org/pandas-docs/stable/basics.html#renaming-mapping-labels) as these are the same idea. |
jreback
added
API Design
Indexing
|
Closing in favor of #15104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff