-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: remove statsmodels as a dependency #15353
Conversation
Codecov Report@@ Coverage Diff @@
## master #15353 +/- ##
==========================================
+ Coverage 86.32% 88.71% +2.38%
==========================================
Files 141 133 -8
Lines 51163 49466 -1697
==========================================
- Hits 44167 43884 -283
+ Misses 6996 5582 -1414
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 !
doc/source/whatsnew/v0.20.0.txt
Outdated
@@ -396,7 +396,7 @@ Removal of prior version deprecations/changes | |||
- The ``pandas.io.ga`` module with a ``google-analytics`` interface is removed (:issue:`11308`). | |||
Similar functionality can be found in the `Google2Pandas <https://github.com/panalysis/Google2Pandas>`__ package. | |||
- ``pd.to_datetime`` and ``pd.to_timedelta`` have dropped the ``coerce`` parameter in favor of ``errors`` (:issue:`13602`) | |||
|
|||
- ``pandas.stats.fama_macbeth``, ``pandas.stats.ols``, ``pandas.stats.plm`` and ``pandas.stats.var``, as well as the top-level ``pandas.fama_macbeth`` and ``pandas.ols`` routines are removed. Similar functionailty can be found in the ``statsmodels`` package. (:issue:`11898`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe make statsmodels a link to its homepage?
ci/requirements-3.5_DOC_BUILD.run
Outdated
@@ -17,5 +17,4 @@ xlsxwriter | |||
sqlalchemy | |||
numexpr | |||
bottleneck | |||
statsmodels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statsmodels is still used for an example in the docs (I think the pipe example), so should leave it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
remove pd.ols, pd.fama_macbeth from top-level namespace xref pandas-dev#11898
a nice way of increasing coverage :> |
remove pd.ols, pd.fama_macbeth from top-level namespace xref pandas-dev#11898 closes wesm/pandas2#26 previously deprecated in 0.18.0 Author: Jeff Reback <jeff@reback.net> Closes pandas-dev#15353 from jreback/stats and squashes the following commits: 9563740 [Jeff Reback] DEPR: remove statsmodels as a dependency
remove pd.ols, pd.fama_macbeth from top-level namespace
xref #11898
closes wesm/pandas2#26
previously deprecated in 0.18.0