Don't add rowspan/colspan if it's 1. #15403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15403 +/- ##
==========================================
- Coverage 90.37% 90.37% -0.01%
==========================================
Files 135 135
Lines 49454 49463 +9
==========================================
+ Hits 44694 44702 +8
- Misses 4760 4761 +1
Continue to review full report at Codecov.
|
jreback
added
IO HTML
|
@QuLogic thanks. Could you check and see if we have any tests of colspan > 1 when there's a MultiIndex in the columns? I see we have one for rowspan > 1 with a MI in the index, but didn't see one for the columns. |
|
I'm not sure where it is, but codecov says it's hitting both |
|
is there any visible effect of this? You can add a whatsnew entry with this PR number just to document. Maybe under Other Enhancements. lgtm. otherwise. |
|
It should be invisible to the user (other than the tables being costing
fewer KB)
…On Thu, Feb 16, 2017 at 8:30 AM, Jeff Reback ***@***.***> wrote:
is there any visible effect of this? You can add a whatsnew entry with
this PR number just to document. Maybe under Other Enhancements. lgtm.
otherwise.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#15403 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIjzxvYx50ntO5WWkkLn3TKQnmUgfks5rdF2MgaJpZM4MBE3l>
.
|
Save a few bytes per row/col and it's already done in the other code path.
QuLogic
force-pushed
the
no-extra-span
branch
from
6ad291f
to
9a8fcee
Compare
|
thanks @QuLogic |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
Just a small thing I noticed in a [footnote here](https://danluu.com/web-bloat/#appendix-irony). Probably can't do much about the extra classes, but rowspan/colspan seem like easy fixes to save a few bytes per row/col and it's already done in the other code path. Author: Elliott Sales de Andrade <quantum.analyst@gmail.com> Closes pandas-dev#15403 from QuLogic/no-extra-span and squashes the following commits: 9a8fcee [Elliott Sales de Andrade] Don't add rowspan/colspan if it's 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small thing I noticed in a footnote here. Probably can't do much about the extra classes, but rowspan/colspan seem like easy fixes to save a few bytes per row/col and it's already done in the other code path.
Don't really know if this is major enough to deserve a what's new entry.
closes #xxxx- N/Agit diff upstream/master | flake8 --diff