-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: support Styler in ExcelFormatter #15530
Closed
Closed
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
ada5101
ENH: support Styler in ExcelFormatter
jnothman f1cde08
FIX column offset incorrect in refactor
jnothman 96680f9
Largely complete CSSToExcelConverter and Styler.to_excel()
jnothman 8780076
Merge branch 'master' into excel_style
jnothman 0ce72f9
Use inherited font size for em_pt
jnothman cb5cf02
Fix bug where inherited not being passed; avoid classmethods
jnothman c589c35
Fix some lint errors (yes, the code needs testing)
jnothman 176e51c
Fix NameError
jnothman d103f61
Refactoring and initial tests for CSS to Excel
jnothman 7db59c0
Test inherited styles in converter
jnothman dc953d4
Font size and border width
jnothman f62f02d
File restructure
jnothman 3b26087
Make get_level_lengths non-private
jnothman eb02cc1
Fix testing ImportError
jnothman 1984cab
Fix making get_level_lengths non-private
jnothman 9a5b791
Fix testing ImportError
jnothman 1a8818f
Lint
jnothman f17a0f4
Some border style tests
jnothman efce9b6
More CSS to Excel testing; define ExcelFormatter.write
jnothman 350eab5
remove spurious blank line
jnothman 306eebe
Module-level docstring
jnothman a1127f6
Merge branch 'master' into excel_style
jnothman a43d6b7
Cleaner imports
jnothman c1fc232
Remove debugging print statements
jnothman 8e9a567
Fixes from integration testing
jnothman 7c54a69
Fix test failures; avoid hair border which renders strangely
jnothman 9a62699
Fix tests and add TODOs to tests
jnothman 433be03
Documentation
jnothman 096f26c
Merge remote-tracking branch 'upstream/master' into excel_style
jnothman b1d774b
What's new heading
jnothman 2c3d015
Fix JSON syntax in IPynb
jnothman c4f59c6
Doc tweaks
jnothman 79eae41
Documentation tweaks
jnothman 6d3ffc6
Lint
jnothman 6ff8a46
Fix loose character; sorry
jnothman 61fdc69
Complete testing basic CSS -> Excel conversions
jnothman d144fdf
Font name strings
jnothman 4e72993
Fix what's new heading
jnothman 60d6a3b
add doc/source/styled.xlsx to the gitignore
jnothman 0256fc6
Return after unhandled font size warning
jnothman d5db0ac
Remove obsolete TODO
jnothman e2cfa77
Test Styler.to_excel
jnothman ceb9171
reasons for xfails
jnothman 3071bac
Complete tests
jnothman 14035c5
Merge branch 'master' into excel_style
jnothman 9669d7d
Require jinja in test with df.style
jnothman 6168765
Recommended changes to what's new
jnothman 6465913
More pytest-like test_styler_to_excel; enhancements to xlwt
jnothman 934df06
Display df, not styled
jnothman a5d51f9
Merge branch 'master' into excel_style
jnothman de53808
Remove debug code
jnothman 836f39e
Revert changes to xlwt
jnothman c7a51ca
Test currently fails on openpyxl1 due to version incompatibilities
jnothman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if uninterested in merging the whole patch, could you consider merging just this refactoring, so that it's easier to extend
ExcelFormatter
?