CLN: Cleanup tests for .rank() #15658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in Progress 1. Created new `pandas/tests/series/test_rank` and `pandas/tests/frame/test_rank` 2. Moved tests from `pandas/tests/test_stats` to `series` or `frame` version of `test_rank` 3. move `rank` tests from `frame/test_analytics` to `frame/test_rank` 4. move `rank` tests from `series/test_analytics` to `series/test_analytics` See pandas-dev#15640
Codecov Report
@@ Coverage Diff @@
## master #15658 +/- ##
==========================================
- Coverage 91.03% 91.01% -0.03%
==========================================
Files 143 143
Lines 49382 49382
==========================================
- Hits 44957 44945 -12
- Misses 4425 4437 +12
Continue to review full report at Codecov.
|
jreback
added
Clean
Testing
|
thanks! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
closes pandas-dev#15640 Author: Rouz Azari <rouz.azari@gmail.com> Closes pandas-dev#15658 from rouzazari/GH15640 and squashes the following commits: d0a2abc [Rouz Azari] Fixed linting error with datetime.datetime import 9580af0 [Rouz Azari] CLN: Cleanup tests for .rank()
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
closes pandas-dev#15640 Author: Rouz Azari <rouz.azari@gmail.com> Closes pandas-dev#15658 from rouzazari/GH15640 and squashes the following commits: d0a2abc [Rouz Azari] Fixed linting error with datetime.datetime import 9580af0 [Rouz Azari] CLN: Cleanup tests for .rank()
rouzazari
added a commit
to rouzazari/pandas
that referenced
this pull request
Apr 5, 2017
1. Moved tests to series-/frame-level test_rank (from test_stats) per pandas-dev#15658. 2. Parametrize `series/test_rank` for `pct=True`.
rouzazari
added a commit
to rouzazari/pandas
that referenced
this pull request
May 22, 2017
1. Moved tests to series-/frame-level test_rank (from test_stats) per pandas-dev#15658. 2. Parametrize `series/test_rank` for `pct=True`.
gfyoung
pushed a commit
to rouzazari/pandas
that referenced
this pull request
Mar 2, 2018
1. Moved tests to series-/frame-level test_rank (from test_stats) per pandas-dev#15658. 2. Parametrize `series/test_rank` for `pct=True`.
gfyoung
pushed a commit
to rouzazari/pandas
that referenced
this pull request
Mar 2, 2018
1. Moved tests to series-/frame-level test_rank (from test_stats) per pandas-dev#15658. 2. Parametrize `series/test_rank` for `pct=True`.
gfyoung
pushed a commit
to rouzazari/pandas
that referenced
this pull request
Mar 8, 2018
1. Moved tests to series-/frame-level test_rank (from test_stats) per pandas-dev#15658. 2. Parametrize `series/test_rank` for `pct=True`.
gfyoung
pushed a commit
to rouzazari/pandas
that referenced
this pull request
Mar 8, 2018
1. Moved tests to series-/frame-level test_rank (from test_stats) per pandas-dev#15658. 2. Parametrize `series/test_rank` for `pct=True`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
ranktests forDataFrameandSeriesto respective test suites.pandas/tests/series/test_rankandpandas/tests/frame/test_rankpandas/tests/test_statstoseriesandframeversion oftest_rankranktests fromframe/test_analyticstoframe/test_rankranktests fromseries/test_analyticstoseries/test_analyticsgit diff upstream/master | flake8 --diff