Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Cleanup for nbsphinx output #15951

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

TomAugspurger
Copy link
Contributor

Followup to #15581

Using the nbsphinx: hidden metadata to hide the ouptut, so
readers don't see matplotlib's fc-list warning.

Make the tables monospaced in CSS.

@TomAugspurger
Copy link
Contributor Author

@jreback is this what you meant by aligned?

screen shot 2017-04-08 at 1 36 21 pm

My change made them use monospace font, but doesn't apply any additional styling.

@jreback
Copy link
Contributor

jreback commented Apr 8, 2017

hmm maybe need to right align the numbers
i thought we do that by default

@TomAugspurger
Copy link
Contributor Author

We probably do in the notebook, but this is picking up the CSS from the website. I'll right-align in the CSS.

Followup to pandas-dev#15581

Using the `nbsphinx: hidden` metadata to hide the ouptut, so
readers don't see matplotlib's fc-list warning.

Make the tables monospaced in CSS.
@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Apr 8, 2017

Fixed

screen shot 2017-04-08 at 2 18 26 pm

@codecov
Copy link

codecov bot commented Apr 8, 2017

Codecov Report

Merging #15951 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15951   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         145      145           
  Lines       49570    49570           
=======================================
  Hits        45106    45106           
  Misses       4464     4464
Flag Coverage Δ
#multiple 88.76% <ø> (ø) ⬆️
#single 40.56% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f5851...99318b7. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 8, 2017

Codecov Report

Merging #15951 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15951      +/-   ##
==========================================
+ Coverage   90.99%   90.99%   +<.01%     
==========================================
  Files         145      145              
  Lines       49570    49570              
==========================================
+ Hits        45106    45107       +1     
+ Misses       4464     4463       -1
Flag Coverage Δ
#multiple 88.76% <ø> (ø) ⬆️
#single 40.56% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f5851...99318b7. Read the comment docs.

@jreback jreback added the Docs label Apr 8, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 8, 2017
@jreback
Copy link
Contributor

jreback commented Apr 8, 2017

@TomAugspurger great! yeah to be honest we should prob default right-align / and fixed decimals for the first thing in the notebook (or I think its the default)?

merge away

@jreback jreback merged commit 0aef74f into pandas-dev:master Apr 8, 2017
@jreback
Copy link
Contributor

jreback commented Apr 8, 2017

thanks @TomAugspurger

@jreback
Copy link
Contributor

jreback commented Apr 8, 2017

font looks nice, though warnings are still there :<

@TomAugspurger
Copy link
Contributor Author

Ah shoot. Looks like you actually have to import matplotlib.pyplot to trigger it (I don't see it locally). I'm doing another PR touching the notebook, I'll throw the fix in there.

@TomAugspurger TomAugspurger deleted the nbsphinx-followup branch May 29, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants