Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: use checkstack level as per comments in groupby.agg with dicts depr testing #15992

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Apr 13, 2017

@jreback jreback added the Testing pandas testing functions or related to the test suite label Apr 13, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 13, 2017
@jorisvandenbossche
Copy link
Member

Let's see what this gives! :-)

(if this fails depending on the python version, we could also skip this depending on that. Although I recall that it was mainly the module deprecation rather than function deprecation that had issues depending on python version)

@jreback jreback merged commit f2ed595 into pandas-dev:master Apr 13, 2017
@jreback
Copy link
Contributor Author

jreback commented Apr 13, 2017

@jorisvandenbossche seemed to work, thanks!

@codecov
Copy link

codecov bot commented Apr 13, 2017

Codecov Report

Merging #15992 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15992      +/-   ##
==========================================
+ Coverage      91%      91%   +<.01%     
==========================================
  Files         145      145              
  Lines       49636    49636              
==========================================
+ Hits        45170    45171       +1     
+ Misses       4466     4465       -1
Flag Coverage Δ
#multiple 88.77% <ø> (ø) ⬆️
#single 40.53% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/groupby.py 95.54% <ø> (ø) ⬆️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4dacb...b2f52d6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants