CLN: move top-level dirs #15998

jreback · 2017-04-14T17:29:21Z

from pandas.types.concat import union_categoricals ?
pandas.types -> pandas.core.typed
pandas.computation -> pandas.core.computation
pandas.sparse -> pandas.core.sparse

jreback · 2017-04-14T17:29:42Z

this was probably the one with the most actual code changes.

jreback · 2017-04-14T17:30:06Z

doc/source/whatsnew/v0.20.0.txt

-Extension Modules Moved
-^^^^^^^^^^^^^^^^^^^^^^^
+Modules Privacy Has Changed
+^^^^^^^^^^^^^^^^^^^^^^^^^^^



we can make this more prominent later.

jreback · 2017-04-14T18:31:19Z

from pandas.types.concat import union_categoricals
we need to change this.

from pandas.api import union_categoricals?

also should change infer_dtype to come from pandas.api as well? (xref #15936) (I will do as a followup I think).

jreback · 2017-04-14T18:31:26Z

cc @chris-b1 @jorisvandenbossche

chris-b1 · 2017-04-14T19:04:42Z

I suppose union_categoricals and infer_dtype should go in pandas.api.types?

jreback · 2017-04-14T19:19:22Z

yep I think that's right place.

jorisvandenbossche · 2017-04-15T00:06:56Z

Is there a reason you use core.typed instead of core.types ?

jreback · 2017-04-15T00:17:15Z

Is there a reason you use core.typed instead of core.types ?

yes, unfortunately in python 2 if you do import types and you are in the pandas.core directly you get pandas.core.types, rather than the built in module (it get shadowed). This is a bit annoying because it does work in python 3 :<

we use this in pandas.core.series. I can get around this, but simpler to just rename.

jorisvandenbossche · 2017-04-15T00:18:52Z

Ah, just saw you commit message that mentioned it as well.
I might prefer 'dtypes' over 'typed', but not that important

codecov · 2017-04-15T01:22:02Z

Codecov Report

Merging #15998 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15998      +/-   ##
==========================================
+ Coverage   91.02%   91.02%   +<.01%     
==========================================
  Files         145      145              
  Lines       50391    50395       +4     
==========================================
+ Hits        45870    45874       +4     
  Misses       4521     4521

Flag	Coverage Δ
#multiple	`88.79% <100%> (-0.04%)`	⬇️
#single	`40.41% <94.2%> (+0.08%)`	⬆️

Impacted Files	Coverage Δ
pandas/core/typed/common.py	`93.27% <ø> (ø)`
pandas/core/computation/common.py	`85.71% <ø> (ø)`
pandas/core/typed/generic.py	`100% <ø> (ø)`
pandas/core/computation/__init__.py	`90.9% <ø> (ø)`
pandas/core/typed/inference.py	`98.33% <ø> (ø)`
pandas/core/typed/api.py	`100% <ø> (ø)`
pandas/core/typed/missing.py	`86.87% <ø> (ø)`
pandas/core/typed/cast.py	`86.89% <ø> (ø)`
pandas/indexes/multi.py	`96.7% <100%> (ø)`	⬆️
pandas/tseries/util.py	`100% <100%> (ø)`	⬆️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a9f8c...a85e487. Read the comment docs.

codecov · 2017-04-15T01:22:20Z

Codecov Report

Merging #15998 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15998      +/-   ##
==========================================
+ Coverage   91.02%   91.02%   +<.01%     
==========================================
  Files         145      145              
  Lines       50391    50395       +4     
==========================================
+ Hits        45870    45874       +4     
  Misses       4521     4521

Flag	Coverage Δ
#multiple	`88.79% <100%> (-0.04%)`	⬇️
#single	`40.41% <94.2%> (+0.08%)`	⬆️

Impacted Files	Coverage Δ
pandas/core/typed/generic.py	`100% <ø> (ø)`
pandas/core/typed/cast.py	`86.89% <ø> (ø)`
pandas/core/typed/common.py	`93.27% <ø> (ø)`
pandas/core/computation/common.py	`85.71% <ø> (ø)`
pandas/core/computation/__init__.py	`90.9% <ø> (ø)`
pandas/core/typed/inference.py	`98.33% <ø> (ø)`
pandas/core/typed/missing.py	`86.87% <ø> (ø)`
pandas/core/typed/api.py	`100% <ø> (ø)`
pandas/indexes/base.py	`96.19% <100%> (ø)`	⬆️
pandas/core/window.py	`96.24% <100%> (ø)`	⬆️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a9f8c...a85e487. Read the comment docs.

codecov · 2017-04-15T01:22:24Z

Codecov Report

Merging #15998 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15998      +/-   ##
==========================================
- Coverage   90.99%   90.99%   -0.01%     
==========================================
  Files         154      153       -1     
  Lines       50474    50481       +7     
==========================================
+ Hits        45931    45937       +6     
- Misses       4543     4544       +1

Flag	Coverage Δ
#multiple	`88.76% <100%> (-0.05%)`	⬇️
#single	`40.44% <91.05%> (+0.08%)`	⬆️

Impacted Files	Coverage Δ
pandas/core/dtypes/missing.py	`86.87% <ø> (ø)`
pandas/core/dtypes/generic.py	`100% <ø> (ø)`
pandas/core/dtypes/cast.py	`86.89% <ø> (ø)`
pandas/core/computation/common.py	`85.71% <ø> (ø)`
pandas/core/dtypes/common.py	`93.27% <ø> (ø)`
pandas/compat/pickle_compat.py	`69.51% <ø> (ø)`	⬆️
pandas/core/dtypes/api.py	`100% <ø> (ø)`
pandas/core/dtypes/inference.py	`98.33% <ø> (ø)`
pandas/core/sparse/scipy_sparse.py	`96.96% <ø> (ø)`
pandas/core/computation/__init__.py	`90.9% <ø> (ø)`
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7993fc8...5fe80ae. Read the comment docs.

jreback · 2017-04-15T15:04:08Z

renamed typed -> dtypes, so a bit more natural now

pandas.core.dtypes

xref pandas-dev#13634

move union_categoricals to pandas.api.types make feather single test fix odd tz hashing issue remove circular import pandas.core.common warning message

jreback · 2017-04-15T23:52:38Z

finally got this bad boy working. apparently pytestdoesn't like nested conftest.py (of course only when you are running using pytest.main(); it works just fine for development.

jorisvandenbossche · 2017-04-16T08:59:41Z

Great!

jreback added the Clean label Apr 14, 2017

jreback added this to the 0.20.0 milestone Apr 14, 2017

jreback commented Apr 14, 2017

View reviewed changes

jreback changed the title ~~CLN: move pandas.types -> pandas.core.types~~ CLN: move pandas.types -> pandas.core.typed Apr 14, 2017

jreback force-pushed the move_types branch from bbc6e30 to 387a9e6 Compare April 14, 2017 18:21

jreback changed the title ~~CLN: move pandas.types -> pandas.core.typed~~ CLN: move top-level dirs Apr 14, 2017

jreback force-pushed the move_types branch from 2a915bc to e98e89f Compare April 14, 2017 23:47

jreback force-pushed the move_types branch from a85e487 to 6933bea Compare April 15, 2017 02:08

jreback mentioned this pull request Apr 15, 2017

CLN/API: move plotting funcs to pandas.plotting #16005

Merged

jreback force-pushed the move_types branch from 6933bea to e6aa91a Compare April 15, 2017 14:25

jreback added 5 commits April 15, 2017 12:04

CLN: move pandas.types -> pandas.core.typed

bbdb1ee

xref pandas-dev#13634

CLN: move pandas.computation -> pandas.core.computation

ba32641

move pandas.api.lib.infer_dtype -> pandas.api.types

290315e

move union_categoricals to pandas.api.types make feather single test fix odd tz hashing issue remove circular import pandas.core.common warning message

rename .typed -> .dtypes

221a7b5

move privacy changes to development section

751fb33

jreback force-pushed the move_types branch 2 times, most recently from b121a57 to c630297 Compare April 15, 2017 19:14

CLN: pandas.sparse -> pandas.core.sparse

f63b76c

jreback force-pushed the move_types branch from 82017f1 to f63b76c Compare April 15, 2017 21:03

jreback added 5 commits April 15, 2017 17:42

try with pyargs

f1505d7

pep

3ca5ba3

more verbose built test

d165a3f

moar ci

9d36104

move fixtures to top-level conftest

5fe80ae

jreback closed this in 005a09e Apr 15, 2017

jorisvandenbossche mentioned this pull request Apr 16, 2017

CLN: updates to benchmarks after repo reorg #16020

Merged

This was referenced Apr 26, 2017

0.20.0 gratuitously breaks backwards compatibility #16138

Closed

Add shim modules with deprecation warnings to ensure backward compat #16140

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLN: move top-level dirs #15998

CLN: move top-level dirs #15998

jreback commented Apr 14, 2017 •

edited

Loading

jreback commented Apr 14, 2017

jreback Apr 14, 2017

jreback commented Apr 14, 2017

jreback commented Apr 14, 2017

chris-b1 commented Apr 14, 2017

jreback commented Apr 14, 2017

jorisvandenbossche commented Apr 15, 2017

jreback commented Apr 15, 2017 •

edited

Loading

jorisvandenbossche commented Apr 15, 2017

codecov bot commented Apr 15, 2017 •

edited

Loading

codecov bot commented Apr 15, 2017

codecov bot commented Apr 15, 2017 •

edited

Loading

jreback commented Apr 15, 2017

jreback commented Apr 15, 2017 •

edited

Loading

jorisvandenbossche commented Apr 16, 2017

CLN: move top-level dirs #15998

CLN: move top-level dirs #15998

Conversation

jreback commented Apr 14, 2017 • edited Loading

jreback commented Apr 14, 2017

jreback Apr 14, 2017

Choose a reason for hiding this comment

jreback commented Apr 14, 2017

jreback commented Apr 14, 2017

chris-b1 commented Apr 14, 2017

jreback commented Apr 14, 2017

jorisvandenbossche commented Apr 15, 2017

jreback commented Apr 15, 2017 • edited Loading

jorisvandenbossche commented Apr 15, 2017

codecov bot commented Apr 15, 2017 • edited Loading

Codecov Report

codecov bot commented Apr 15, 2017

Codecov Report

codecov bot commented Apr 15, 2017 • edited Loading

Codecov Report

jreback commented Apr 15, 2017

jreback commented Apr 15, 2017 • edited Loading

jorisvandenbossche commented Apr 16, 2017

jreback commented Apr 14, 2017 •

edited

Loading

jreback commented Apr 15, 2017 •

edited

Loading

codecov bot commented Apr 15, 2017 •

edited

Loading

codecov bot commented Apr 15, 2017 •

edited

Loading

jreback commented Apr 15, 2017 •

edited

Loading