Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 'n/a' to list of strings denoting missing values #16079

Merged
merged 10 commits into from
Jun 2, 2017
Merged

Adding 'n/a' to list of strings denoting missing values #16079

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed05de7
Added 'n/a' as a missing value (TDD)
chrisgorgo Apr 20, 2017
b82d850
Adding 'n/a'
chrisgorgo Apr 20, 2017
c6de730
Adding 'n/a'
chrisgorgo Apr 20, 2017
26a5c1f
adding 'n/a'
chrisgorgo Apr 20, 2017
54a8068
whats new
chrisgorgo Apr 20, 2017
f1d4c66
quotes
chrisgorgo Apr 21, 2017
8486f71
changelog
chrisgorgo May 19, 2017
23b7df8
Merge branch 'master' into patch-1
chrisgorgo Jun 1, 2017
091a6de
making flake8 happy
chrisgorgo Jun 2, 2017
eef689a
codify whatsnew for added na values
jreback Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/io.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ NA and Missing Data Handling
na_values : scalar, str, list-like, or dict, default ``None``
Additional strings to recognize as NA/NaN. If dict passed, specific per-column
NA values. By default the following values are interpreted as NaN:
``'-1.#IND', '1.#QNAN', '1.#IND', '-1.#QNAN', '#N/A N/A', '#N/A', 'N/A', 'NA',
``'-1.#IND', '1.#QNAN', '1.#IND', '-1.#QNAN', '#N/A N/A', '#N/A', 'N/A', 'n/a', 'NA',
'#NA', 'NULL', 'null', 'NaN', '-NaN', 'nan', '-nan', ''``.
keep_default_na : boolean, default ``True``
If na_values are specified and keep_default_na is ``False`` the default NaN
Expand Down
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.21.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ Backwards incompatible API changes

- Accessing a non-existent attribute on a closed :class:`HDFStore` will now
raise an ``AttributeError`` rather than a ``ClosedFileError`` (:issue:`16301`)
- ``pd.read_csv()`` now treats ``'n/a'`` strings as missing values by default (:issue:`16078`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this right below the other issue (where null is added)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could, but @jorisvandenbossche made exactly the opposite request: #16079 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh I see. then I will move the other one here :>


.. _whatsnew_0210.api:

Expand Down
2 changes: 1 addition & 1 deletion pandas/_libs/parsers.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ DEFAULT_CHUNKSIZE = 256 * 1024
# no longer excluding inf representations
# '1.#INF','-1.#INF', '1.#INF000000',
_NA_VALUES = [b'-1.#IND', b'1.#QNAN', b'1.#IND', b'-1.#QNAN',
b'#N/A N/A', b'NA', b'#NA', b'NULL', b'null', b'NaN',
b'#N/A N/A', b'n/a', b'NA', b'#NA', b'NULL', b'null', b'NaN',
b'nan', b'']


Expand Down
2 changes: 1 addition & 1 deletion pandas/io/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
# '1.#INF','-1.#INF', '1.#INF000000',
_NA_VALUES = set([
'-1.#IND', '1.#QNAN', '1.#IND', '-1.#QNAN', '#N/A N/A', '#N/A',
'N/A', 'NA', '#NA', 'NULL', 'null', 'NaN', '-NaN', 'nan', '-nan', ''
'N/A', 'n/a', 'NA', '#NA', 'NULL', 'null', 'NaN', '-NaN', 'nan', '-nan', ''
])

try:
Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/io/parser/na_values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ def test_non_string_na_values(self):

def test_default_na_values(self):
_NA_VALUES = set(['-1.#IND', '1.#QNAN', '1.#IND', '-1.#QNAN',
'#N/A', 'N/A', 'NA', '#NA', 'NULL', 'null', 'NaN',
'nan', '-NaN', '-nan', '#N/A N/A', ''])
'#N/A', 'N/A', 'n/a', 'NA', '#NA', 'NULL', 'null',
'NaN', 'nan', '-NaN', '-nan', '#N/A N/A', ''])
assert _NA_VALUES == parsers._NA_VALUES
nv = len(_NA_VALUES)

Expand Down