Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix table styling in main docs #16145

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

TomAugspurger
Copy link
Contributor

When switching to nbsphinx, I modified the site's CSS so
that the converted notebook looks decent. This had some
unfortunate changes on tables elsewhere in the notebook.

This change fixes the headers to be left-aligned in the main site,
and right-aligned for the tables generated by df.style in the
nbsphinx-converted notebook.

xref #15581

Before:
screen shot 2017-04-26 at 7 11 19 am

After:

screen shot 2017-04-26 at 8 23 43 am

When switching to nbsphinx, I modified the site's CSS so
that the converted notebook looks decent. This had some
unfortunate changes on tables elsewhere in the notebook.

This change fixes the headers to be left-aligned in the main site,
and right-aligned for the tables generated by `df.style` in the
nbsphinx-converted notebook.

xref pandas-dev#15581
@TomAugspurger TomAugspurger added this to the 0.20.0 milestone Apr 26, 2017
@jreback
Copy link
Contributor

jreback commented Apr 26, 2017

@TomAugspurger

When switching to nbsphinx, I modified the site's CSS so
that the converted notebook looks decent. This had some
unfortunate changes on tables elsewhere in the notebook.

what is this modification (I am needing to steal for another project).
nbsphinx is very nice btw.

@TomAugspurger
Copy link
Contributor Author

what is this modification

Just the diff here. Rather than applying the text-align: right to all ths on the site, it only applies to ths with the col_heading class. .style includes col_heading in the generated HTML for headers.

@codecov
Copy link

codecov bot commented Apr 26, 2017

Codecov Report

Merging #16145 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16145      +/-   ##
==========================================
+ Coverage   90.83%   90.86%   +0.02%     
==========================================
  Files         159      159              
  Lines       50787    50787              
==========================================
+ Hits        46134    46146      +12     
+ Misses       4653     4641      -12
Flag Coverage Δ
#multiple 88.64% <ø> (+0.02%) ⬆️
#single 40.32% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.35% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ca022...b37c518. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 26, 2017

Codecov Report

Merging #16145 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16145      +/-   ##
==========================================
+ Coverage   90.83%   90.86%   +0.02%     
==========================================
  Files         159      159              
  Lines       50787    50787              
==========================================
+ Hits        46134    46146      +12     
+ Misses       4653     4641      -12
Flag Coverage Δ
#multiple 88.64% <ø> (+0.02%) ⬆️
#single 40.32% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.35% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ca022...b37c518. Read the comment docs.

@TomAugspurger TomAugspurger merged commit a8aa2e1 into pandas-dev:master Apr 26, 2017
@TomAugspurger TomAugspurger deleted the doc-css branch May 1, 2017 15:50
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
When switching to nbsphinx, I modified the site's CSS so
that the converted notebook looks decent. This had some
unfortunate changes on tables elsewhere in the notebook.

This change fixes the headers to be left-aligned in the main site,
and right-aligned for the tables generated by `df.style` in the
nbsphinx-converted notebook.

xref pandas-dev#15581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants