PERF: don't materialize arrays on checking in groupby #16413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16413 +/- ##
==========================================
+ Coverage 90.41% 90.42% +0.01%
==========================================
Files 161 161
Lines 51024 51023 -1
==========================================
+ Hits 46133 46138 +5
+ Misses 4891 4885 -6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16413 +/- ##
==========================================
+ Coverage 90.41% 90.42% +0.01%
==========================================
Files 161 161
Lines 51024 51023 -1
==========================================
+ Hits 46133 46138 +5
+ Misses 4891 4885 -6
Continue to review full report at Codecov.
|
pcluo
pushed a commit
to pcluo/pandas
that referenced
this pull request
May 22, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
May 29, 2017
(cherry picked from commit d5a681b)
TomAugspurger
pushed a commit
that referenced
this pull request
May 30, 2017
(cherry picked from commit d5a681b)
This was referenced Jun 4, 2017
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is more dramatic as the size increases as this should be pretty much a constant time operation (the actual size computation itself).