Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH10559: Minor improvement: Change read_excel sheet name #16442

Merged
merged 5 commits into from
May 23, 2017
Merged

GH10559: Minor improvement: Change read_excel sheet name #16442

merged 5 commits into from
May 23, 2017

Commits on May 22, 2017

  1. GH10559: Minor improvement: Change to_excel sheet name

    modify io/excel.py and relevant docs (io.rst) to use sheet_name for read_excel
    but allow sheetname to still be used for backwards compatibility.  add test_excel
    to verify that sheet_name and sheetname args produce the same result.
    Aaron Barber committed May 22, 2017
    Configuration menu
    Copy the full SHA
    23a0cec View commit details
    Browse the repository at this point in the history

Commits on May 23, 2017

  1. GH10559: Minor improvement: Change to_excel sheet name

    added @deprecate_kwarg to read_excel as arg changes from sheetname to sheet_name.
    moved test comments into function, add assert_produces_warning.
    Aaron Barber committed May 23, 2017
    Configuration menu
    Copy the full SHA
    5a59cd0 View commit details
    Browse the repository at this point in the history
  2. GH10559: Minor improvement: Change to_excel sheet name

    remove manual arg change, use @deprecate_kwarg to read_excel
    as arg changes from sheetname to sheet_name.
    Aaron Barber committed May 23, 2017
    Configuration menu
    Copy the full SHA
    4171dd6 View commit details
    Browse the repository at this point in the history
  3. GH10559: Minor improvement: Change to_excel sheet name

    shorten lines under 79 char.
    Aaron Barber committed May 23, 2017
    Configuration menu
    Copy the full SHA
    91438b8 View commit details
    Browse the repository at this point in the history
  4. GH10559: Minor improvement: Change to_excel sheet name

    update whats new 0.21.0 Deprecations section noting sheetname deprecated
    in favor of sheet_name.
    add sheetname deprecation in read_excel() docstring.
    Aaron Barber committed May 23, 2017
    Configuration menu
    Copy the full SHA
    4c6da13 View commit details
    Browse the repository at this point in the history