-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: writing invalid table names to sqlite #16464
Conversation
pandas/tests/io/test_sql.py
Outdated
# GH 13206 | ||
df = DataFrame({'A': [0, 1, 2], 'B': [0.2, np.nan, 5.6]}) | ||
df.to_sql('d1187b08-4943-4c8d-a7f6-6c06b7cb9509', self.conn, index=False) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you read this back and compare
…fixes coding style violation.
Codecov Report
@@ Coverage Diff @@
## master #16464 +/- ##
=======================================
Coverage 90.42% 90.42%
=======================================
Files 161 161
Lines 51027 51027
=======================================
Hits 46142 46142
Misses 4885 4885
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16464 +/- ##
==========================================
+ Coverage 90.42% 90.79% +0.37%
==========================================
Files 161 161
Lines 51027 51063 +36
==========================================
+ Hits 46142 46365 +223
+ Misses 4885 4698 -187
Continue to review full report at Codecov.
|
@jreback I've added the additional verification, and all checks are now passing. |
Thanks! |
* Add test for bug pandas-dev#13206. * Improve test by reading back the values from sql and comparing. Also fixes coding style violation.
* Add test for bug pandas-dev#13206. * Improve test by reading back the values from sql and comparing. Also fixes coding style violation.
I verified that the test exposes the bug prior to the fix for bug #13206.
Pandas from master
Pandas 0.13.1