-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Make HDF5 fspath write test robust #16575
Conversation
The test_write_fspath_all test would fail on the HDF5 example occasionally (about 1/100 in my experience). Apparently you don't get an identical HDF5 every single time. This refactors that test out to its own where we write and read both versions, and compare equality that way.
Codecov Report
@@ Coverage Diff @@
## master #16575 +/- ##
==========================================
- Coverage 90.78% 90.75% -0.03%
==========================================
Files 161 161
Lines 51089 51089
==========================================
- Hits 46380 46368 -12
- Misses 4709 4721 +12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16575 +/- ##
==========================================
- Coverage 90.78% 90.75% -0.03%
==========================================
Files 161 161
Lines 51089 51089
==========================================
- Hits 46380 46368 -12
- Misses 4709 4721 +12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16575 +/- ##
==========================================
- Coverage 90.78% 90.75% -0.03%
==========================================
Files 161 161
Lines 51089 51089
==========================================
- Hits 46380 46368 -12
- Misses 4709 4721 +12
Continue to review full report at Codecov.
|
thanks! |
you might want to backport this? up 2 u |
I think the fspath stuff was 0.21.0 (since it had that minor API change on HDFStore's getattr) |
ahh right I remember your comment. thanks. |
The test_write_fspath_all test would fail on the HDF5 example occasionally (about 1/100 in my experience). Apparently you don't get an identical HDF5 every single time. This refactors that test out to its own where we write and read both versions, and compare equality that way.
The test_write_fspath_all test would fail on the HDF5 example occasionally (about 1/100 in my experience). Apparently you don't get an identical HDF5 every single time. This refactors that test out to its own where we write and read both versions, and compare equality that way.
The test_write_fspath_all test would fail on the HDF5 example
occasionally (about 1/100 in my experience). Apparently you don't get an
identical HDF5 every single time. This refactors that test out to its own where
we write and read both versions, and compare equality that way.
See #14026 (comment) and https://circleci.com/gh/pandas-dev/pandas/2507?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link for an example