Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some lgtm alerts #16613

Merged
merged 8 commits into from
Jun 7, 2017
Merged

Fix some lgtm alerts #16613

merged 8 commits into from
Jun 7, 2017

Conversation

jhelie
Copy link
Contributor

@jhelie jhelie commented Jun 6, 2017

Hi,
I just wanted to quickly fix a few alerts flagged up by lgtm.com. These are mostly simple ones but they were a few misnamed arguments in some calls.

A total of 209 alerts have been found by lgtm.com, you can enable PR integration for automated PR reviews and flag these in the future before they find their way to the code base.
https://lgtm.com/projects/g/pydata/pandas/

I'm a big fan of pandas, I hope you'll find these useful!

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master --name-only -- '*.py' | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Jun 6, 2017

Codecov Report

Merging #16613 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16613      +/-   ##
==========================================
+ Coverage   90.93%   90.93%   +<.01%     
==========================================
  Files         161      161              
  Lines       49267    49263       -4     
==========================================
- Hits        44800    44798       -2     
+ Misses       4467     4465       -2
Flag Coverage Δ
#multiple 88.69% <66.66%> (ø) ⬆️
#single 40.22% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/tseries/offsets.py 97.12% <ø> (-0.01%) ⬇️
pandas/core/internals.py 93.43% <ø> (+0.03%) ⬆️
pandas/io/parsers.py 95.43% <0%> (ø) ⬆️
pandas/core/dtypes/cast.py 86.89% <0%> (ø) ⬆️
pandas/core/sparse/array.py 91.46% <100%> (ø) ⬆️
pandas/core/indexes/interval.py 92.58% <100%> (ø) ⬆️
pandas/core/generic.py 92.36% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697d026...eecbbb8. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2017

Codecov Report

Merging #16613 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16613      +/-   ##
==========================================
+ Coverage   90.93%   90.93%   +<.01%     
==========================================
  Files         161      161              
  Lines       49267    49263       -4     
==========================================
- Hits        44800    44798       -2     
+ Misses       4467     4465       -2
Flag Coverage Δ
#multiple 88.69% <66.66%> (ø) ⬆️
#single 40.22% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals.py 93.43% <ø> (+0.03%) ⬆️
pandas/tseries/offsets.py 97.12% <ø> (-0.01%) ⬇️
pandas/core/dtypes/cast.py 86.89% <0%> (ø) ⬆️
pandas/io/parsers.py 95.43% <0%> (ø) ⬆️
pandas/core/sparse/array.py 91.46% <100%> (ø) ⬆️
pandas/core/indexes/interval.py 92.58% <100%> (ø) ⬆️
pandas/core/generic.py 92.36% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697d026...eecbbb8. Read the comment docs.

@jreback jreback added the Clean label Jun 7, 2017
@jreback jreback added this to the 0.21.0 milestone Jun 7, 2017
@jreback
Copy link
Contributor

jreback commented Jun 7, 2017

thanks these look like good catches. This is all deprecated / not heavily tested code so makes sense that the style checker found this.

@jreback jreback merged commit 10c17d4 into pandas-dev:master Jun 7, 2017
@jreback
Copy link
Contributor

jreback commented Jun 7, 2017

so is there something we can hook up thru github to check this?

@jhelie
Copy link
Contributor Author

jhelie commented Jun 7, 2017

@jreback absolutely, you can activate it at https://lgtm.com/projects/g/pydata/pandas/ci/ once you've logged in with your GitHub account
see https://lgtm.com/docs/lgtm/config/pr-integration for details

Kiv pushed a commit to Kiv/pandas that referenced this pull request Jun 11, 2017
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
@jhelie jhelie deleted the fix-some-lgtm-alerts branch August 4, 2017 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants