-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some lgtm alerts #16613
Fix some lgtm alerts #16613
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16613 +/- ##
==========================================
+ Coverage 90.93% 90.93% +<.01%
==========================================
Files 161 161
Lines 49267 49263 -4
==========================================
- Hits 44800 44798 -2
+ Misses 4467 4465 -2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16613 +/- ##
==========================================
+ Coverage 90.93% 90.93% +<.01%
==========================================
Files 161 161
Lines 49267 49263 -4
==========================================
- Hits 44800 44798 -2
+ Misses 4467 4465 -2
Continue to review full report at Codecov.
|
thanks these look like good catches. This is all deprecated / not heavily tested code so makes sense that the style checker found this. |
so is there something we can hook up thru github to check this? |
@jreback absolutely, you can activate it at https://lgtm.com/projects/g/pydata/pandas/ci/ once you've logged in with your GitHub account |
Hi,
I just wanted to quickly fix a few alerts flagged up by lgtm.com. These are mostly simple ones but they were a few misnamed arguments in some calls.
A total of 209 alerts have been found by lgtm.com, you can enable PR integration for automated PR reviews and flag these in the future before they find their way to the code base.
https://lgtm.com/projects/g/pydata/pandas/
I'm a big fan of pandas, I hope you'll find these useful!
git diff upstream/master --name-only -- '*.py' | flake8 --diff