BUG: Fix Series.get failure on missing NaN (#8569) #16619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsm054
force-pushed
the
bugfix/series_get_nan
branch
from
470eeb5
to
4293830
Compare
Codecov Report
@@ Coverage Diff @@
## master #16619 +/- ##
==========================================
- Coverage 90.96% 90.93% -0.03%
==========================================
Files 161 161
Lines 49263 49265 +2
==========================================
- Hits 44810 44800 -10
- Misses 4453 4465 +12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16619 +/- ##
==========================================
- Coverage 90.96% 90.93% -0.03%
==========================================
Files 161 161
Lines 49263 49265 +2
==========================================
- Hits 44810 44800 -10
- Misses 4453 4465 +12
Continue to review full report at Codecov.
|
jreback
added
Bug
Indexing
|
thanks! |
Kiv
pushed a commit
to Kiv/pandas
that referenced
this pull request
Jun 11, 2017
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Jul 6, 2017
…dev#16619) (cherry picked from commit 2b44868)
TomAugspurger
pushed a commit
that referenced
this pull request
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle obscure case where
.get(np.nan)wouldn't behave as expected. Fortunately the only change needed is within the unlikely branch, and so performance of get shouldn't be affected at all in the ordinary case.[X] fixes #8569
[X] tests added / passed
[X] passes git diff upstream/master --name-only -- '*.py' | flake8 --diff
[X] whatsnew entry