Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add test for groupby sum of large ints #16671

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jun 11, 2017

Title is self-explanatory. Closes #14758.

@gfyoung gfyoung force-pushed the test-for-14758 branch 2 times, most recently from 43a734e to 0d60740 Compare June 11, 2017 22:30
@jreback jreback added Groupby Testing pandas testing functions or related to the test suite Dtype Conversions Unexpected or buggy dtype conversions labels Jun 11, 2017
@jreback jreback added this to the 0.21.0 milestone Jun 11, 2017
@jreback
Copy link
Contributor

jreback commented Jun 11, 2017

lgtm. ping on green.

@codecov
Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #16671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16671   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files         161      161           
  Lines       49272    49272           
=======================================
  Hits        44803    44803           
  Misses       4469     4469
Flag Coverage Δ
#multiple 88.69% <ø> (ø) ⬆️
#single 40.22% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0281886...6ed6f4e. Read the comment docs.

@gfyoung
Copy link
Member Author

gfyoung commented Jun 12, 2017

@jreback : All green and ready to merge.

@jreback jreback merged commit b72519e into pandas-dev:master Jun 12, 2017
@jreback
Copy link
Contributor

jreback commented Jun 12, 2017

thanks!

@gfyoung gfyoung deleted the test-for-14758 branch June 13, 2017 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants