Move series.remove_na to core.dtypes.missing.remove_na_arraylike

[jbrockmendel]

See discussion on #16931.

[pep8speaks]

Hello @jbrockmendel! Thanks for updating the PR.

• In the file pandas/core/series.py, following are the PEP8 issues :

Line 579:9: E722 do not use bare except'
Line 657:17: E722 do not use bare except'
Line 800:17: E722 do not use bare except'
Line 2158:13: E731 do not assign a lambda expression, use a def
Line 2174:17: E731 do not assign a lambda expression, use a def
Line 2370:13: E731 do not assign a lambda expression, use a def
Line 2764:5: E731 do not assign a lambda expression, use a def

• In the file pandas/tests/test_panel.py, following are the PEP8 issues :

Line 82:9: E731 do not assign a lambda expression, use a def
Line 346:17: E722 do not use bare except'
Line 352:17: E722 do not use bare except'
Line 1347:13: E731 do not assign a lambda expression, use a def
Line 2529:21: E731 do not assign a lambda expression, use a def

• In the file pandas/tests/test_panel4d.py, following are the PEP8 issues :

Line 36:9: E731 do not assign a lambda expression, use a def

Comment last updated on July 15, 2017 at 17:38 Hours UTC

[jreback]

ignore the pep8speaks for now
we r testing it out

[gfyoung]

I know you and @jreback discussed this briefly, but I'd like to understand this:

Why are you saying "array-like" when the function only accepts Series (or is only meant for Series)? If it isn't meant just for Series, we should update the documentation to reflect this new behavior.

[gfyoung]

Let's add tests as well for this function just to make sure it behaves like we want it too.

[jreback]

ok with tests. the name is fine. its descriptive and actually works on arrays as well.

yes if you can throw in a couple of tests (with parametrize) would be great.

[gfyoung]

In that case, we should rename the variable name to something like array_like along with a description of accepted data types.

[jreback]

sure you can name it arr (our typical name)

[gfyoung]

@jbrockmendel : Just a minor style error, but otherwise, everything looks green. 👍

[jbrockmendel]

What's the style error?

[gfyoung]

The style error can be found here. Address that, and then all builds will pass.

[codecov]

Codecov Report

Merging #16935 into master will decrease coverage by 0.01%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master   #16935      +/-   ##
==========================================
- Coverage   90.99%   90.98%   -0.02%     
==========================================
  Files         161      161              
  Lines       49306    49306              
==========================================
- Hits        44868    44859       -9     
- Misses       4438     4447       +9

Flag	Coverage Δ
#multiple	88.75% <90%> (ø)	⬆️
#single	40.19% <40%> (-0.07%)	⬇️

Impacted Files	Coverage Δ
pandas/core/dtypes/missing.py	87.03% <100%> (+0.16%)	⬆️
pandas/core/series.py	94.89% <100%> (-0.01%)	⬇️
pandas/plotting/_core.py	82.52% <83.33%> (ø)	⬆️
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/core/frame.py	97.71% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6858d0f...18a5610. Read the comment docs.

[codecov]

Codecov Report

Merging #16935 into master will decrease coverage by 0.02%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master   #16935      +/-   ##
==========================================
- Coverage   90.99%   90.96%   -0.03%     
==========================================
  Files         161      161              
  Lines       49306    49288      -18     
==========================================
- Hits        44868    44837      -31     
- Misses       4438     4451      +13

Flag	Coverage Δ
#multiple	88.74% <90%> (-0.02%)	⬇️
#single	40.2% <40%> (-0.06%)	⬇️

Impacted Files	Coverage Δ
pandas/core/series.py	94.89% <100%> (-0.01%)	⬇️
pandas/core/dtypes/missing.py	87.03% <100%> (+0.16%)	⬆️
pandas/plotting/_core.py	82.52% <83.33%> (ø)	⬆️
pandas/io/gbq.py	25% <0%> (-58.34%)	⬇️
pandas/plotting/_converter.py	63.23% <0%> (-1.82%)	⬇️
pandas/compat/__init__.py	60.67% <0%> (-1.55%)	⬇️
pandas/core/frame.py	97.76% <0%> (-0.05%)	⬇️
pandas/core/generic.py	92.29% <0%> (ø)	⬆️
pandas/core/panel.py	96.94% <0%> (ø)	⬆️
pandas/core/indexes/multi.py	96.91% <0%> (+0.24%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6858d0f...18a5610. Read the comment docs.

[jreback]

lgtm

ping on green

[gfyoung]

Thanks @jbrockmendel !