DEPR #16747: deprecate pd.TimeGrouper #16942
Conversation
|
Hello @stevemontana1980! Thanks for updating the PR.
Comment last updated on July 15, 2017 at 12:42 Hours UTC |
pandas/tests/api/test_api.py
Outdated
| 'TimedeltaIndex', 'Timestamp', 'Interval', 'IntervalIndex'] | ||
|
|
||
| # these are already deprecated; awaiting removal | ||
| deprecated_classes = ['WidePanel', 'Panel4D', | ||
| 'SparseList', 'Expr', 'Term'] | ||
|
|
||
| # these should be deprecated in the future | ||
| deprecated_classes_in_future = ['Panel'] | ||
| deprecated_classes_in_future = ['Panel', 'TimeGrouper'] |
There was a problem hiding this comment.
I think TimeGrouper should go in the deprecated_classes list.
pandas/tests/test_resample.py
Outdated
| @@ -3030,6 +3030,11 @@ def setup_method(self, method): | |||
| self.ts = Series(np.random.randn(1000), | |||
| index=date_range('1/1/2000', periods=1000)) | |||
|
|
|||
| def test_TimeGrouper_deprecation(self): | |||
| # deprecation TimeGrouper, #16747 | |||
There was a problem hiding this comment.
Usually we write these as # GH #16747
There was a problem hiding this comment.
Thank, changes committed. I'm new at this, so thanks for your patience.
Codecov Report
@@ Coverage Diff @@
## master #16942 +/- ##
==========================================
+ Coverage 90.98% 90.98% +<.01%
==========================================
Files 161 161
Lines 49306 49307 +1
==========================================
+ Hits 44859 44860 +1
Misses 4447 4447
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16942 +/- ##
==========================================
- Coverage 90.99% 90.98% -0.02%
==========================================
Files 161 161
Lines 49306 49307 +1
==========================================
- Hits 44868 44860 -8
- Misses 4438 4447 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
- pls add a line in whatsnew (deprecations sections).
- run tests where this appears locally (e.g. the resample / groupby tests). we need to suppress this error where it is used now. so you need to change any instances of use of
TimeGrouperto useGrouper(there are a few). but of course leave the tests on the deprecated one.
jreback
added
Deprecate
|
can you rebase and update according to comments. |
|
can you rebase / update |
|
closing in favor of #17703 |
git diff upstream/master -u -- "*.py" | flake8 --diff