Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating Series.argmin and Series.argmax (#16830) #16955

Merged
merged 13 commits into from
Sep 27, 2017

Commits on Sep 19, 2017

  1. Deprecating Series.argmin and Series.argmax (pandas-dev#16830)

    Added statements about correcting behavior in future commit
    
    Add reference to github ticket
    
    Fixing placement of github comment
    
    Made test code more explicit
    
    Fixing unrelated tests that are also throwing warnings
    
    Updating whatsnew to give more detail about deprecation
    
    Fixing whatsnew and breaking out tests to catch warnings
    
    Additional comments and more concise whatsnew
    
    Updating deprecate decorator to support custom message
    
    DOC: Update docstrings, depr message, and whatsnew
    Lucas Kushner authored and TomAugspurger committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    676bb50 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2017

  1. Added debug prints

    TomAugspurger committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    578dbd5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c770b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2017

  1. Reword whatsnew

    TomAugspurger committed Sep 24, 2017
    Configuration menu
    Copy the full SHA
    0e039de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db08dda View commit details
    Browse the repository at this point in the history
  3. Skip on py2

    TomAugspurger committed Sep 24, 2017
    Configuration menu
    Copy the full SHA
    080fb06 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2017

  1. Change to idxmin

    TomAugspurger committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    e979c60 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3d3581 View commit details
    Browse the repository at this point in the history
  3. Remove py2 skips

    TomAugspurger committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    b2501b2 View commit details
    Browse the repository at this point in the history
  4. Catch more warnings

    TomAugspurger committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    7ebf9cd View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2017

  1. Final switch to idxmax

    TomAugspurger committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    128f8d4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e106a18 View commit details
    Browse the repository at this point in the history
  3. Fixed tests

    TomAugspurger committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    426d8eb View commit details
    Browse the repository at this point in the history