-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test for boto3 #17136
Fix test for boto3 #17136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17136 +/- ##
==========================================
- Coverage 91.03% 90.98% -0.05%
==========================================
Files 161 161
Lines 49405 49405
==========================================
- Hits 44974 44950 -24
- Misses 4431 4455 +24
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #17136 +/- ##
==========================================
- Coverage 91.03% 90.98% -0.05%
==========================================
Files 161 161
Lines 49405 49405
==========================================
- Hits 44974 44950 -24
- Misses 4431 4455 +24
Continue to review full report at Codecov.
|
@uiureo : For us to accept this patch, we would need you to patch existing behavior, not just fix the test to reproduce a failure. |
@uiureo can you make this into an xfailing test. note that |
can you rebase and update according to comments. |
closing as stale |
git diff upstream/master -u -- "*.py" | flake8 --diff
This is a failing test for #17135 to reproduce the behavior.