Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: fix setup.py for xref #17798 #17804

Merged
merged 1 commit into from
Oct 6, 2017
Merged

BLD: fix setup.py for xref #17798 #17804

merged 1 commit into from
Oct 6, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Oct 6, 2017 •
edited
Loading

xref #17798

@jreback jreback added the Build Library building on various platforms label Oct 6, 2017
@jreback jreback added this to the 0.21.0 milestone Oct 6, 2017
@jreback
Copy link
Contributor Author

jreback commented Oct 6, 2017

cc @TomAugspurger

@TomAugspurger
Copy link
Contributor

Ah sorry about that. When you said "which IS picking this up", I thought you meant the setup.py was finding it, not that the test was correctly failing it.

@jreback
Copy link
Contributor Author

jreback commented Oct 6, 2017

np

@jreback jreback merged commit 5bb693a into pandas-dev:master Oct 6, 2017
@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #17804 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17804      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       49971    49971              
==========================================
- Hits        45599    45590       -9     
- Misses       4372     4381       +9
Flag Coverage Δ
#multiple 89.03% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.74% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4121b...185b41d. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 6, 2017 •
edited
Loading

Codecov Report

Merging #17804 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17804      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       49971    49971              
==========================================
- Hits        45599    45590       -9     
- Misses       4372     4381       +9
Flag Coverage Δ
#multiple 89.03% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.74% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4121b...185b41d. Read the comment docs.

ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
@jreback
BLD: fix setup.py for xref pandas-dev#17798 (pandas-dev#17804)
a8d5bfc
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
@jreback @alanbato
BLD: fix setup.py for xref pandas-dev#17798 (pandas-dev#17804)
183bb03
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@jreback @No-Stream
BLD: fix setup.py for xref pandas-dev#17798 (pandas-dev#17804)
2765ccc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jreback @TomAugspurger