Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: set tz on DTI from fixed format HDFStore #17844

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

jjhelmus
Copy link
Contributor

@jjhelmus jjhelmus commented Oct 11, 2017

Set the tz after creating the DatetimeIndex instance when reading from a fixed
format HDFStore. Setting the tz during instance creation offset data.

closes #17618

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Set the tz after creating the DatetimeIndex instance when reading from a fixed
format HDFStore. Setting the tz during instance creation offset data.

closes pandas-dev#17618
@codecov
Copy link

codecov bot commented Oct 11, 2017

Codecov Report

Merging #17844 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17844      +/-   ##
==========================================
+ Coverage   91.22%   91.23%   +<.01%     
==========================================
  Files         163      163              
  Lines       50014    50014              
==========================================
+ Hits        45627    45630       +3     
+ Misses       4387     4384       -3
Flag Coverage Δ
#multiple 89.04% <100%> (+0.02%) ⬆️
#single 40.25% <100%> (-0.05%) ⬇️
Impacted Files Coverage Δ
pandas/io/pytables.py 92.79% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727ea20...e92349e. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 11, 2017

Codecov Report

Merging #17844 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17844      +/-   ##
==========================================
+ Coverage   91.22%   91.23%   +<.01%     
==========================================
  Files         163      163              
  Lines       50014    50014              
==========================================
+ Hits        45627    45630       +3     
+ Misses       4387     4384       -3
Flag Coverage Δ
#multiple 89.04% <100%> (+0.02%) ⬆️
#single 40.25% <100%> (-0.05%) ⬇️
Impacted Files Coverage Δ
pandas/io/pytables.py 92.79% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727ea20...e92349e. Read the comment docs.

@gfyoung gfyoung added Bug IO HDF5 read_hdf, HDFStore Timezones Timezone data dtype labels Oct 12, 2017
@jreback jreback added this to the 0.21.0 milestone Oct 13, 2017
@jreback jreback merged commit 0926b2d into pandas-dev:master Oct 13, 2017
@jreback
Copy link
Contributor

jreback commented Oct 13, 2017

thanks!

buntwo pushed a commit to buntwo/pandas that referenced this pull request Oct 14, 2017
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
* upstream/master: (76 commits)
  CategoricalDtype construction: actually use fastpath (pandas-dev#17891)
  DEPR: Deprecate tupleize_cols in to_csv (pandas-dev#17877)
  BUG: Fix wrong column selection in drop_duplicates when duplicate column names (pandas-dev#17879)
  DOC: Adding examples to update docstring (pandas-dev#16812) (pandas-dev#17859)
  TST: Skip if no openpyxl in test_excel (pandas-dev#17883)
  TST: Catch read_html slow test warning (pandas-dev#17874)
  flake8 cleanup (pandas-dev#17873)
  TST: remove moar warnings (pandas-dev#17872)
  ENH: tolerance now takes list-like argument for reindex and get_indexer. (pandas-dev#17367)
  ERR: Raise ValueError when week is passed in to_datetime format witho… (pandas-dev#17819)
  TST: remove some deprecation warnings (pandas-dev#17870)
  Refactor index-as-string groupby tests and fix spurious warning (Bug 17383) (pandas-dev#17843)
  BUG: merging with a boolean/int categorical column (pandas-dev#17841)
  DEPR: Deprecate read_csv arguments fully (pandas-dev#17865)
  BUG: to_json - prevent various segfault conditions (GH14256) (pandas-dev#17857)
  CLN: Use pandas.core.common for None checks (pandas-dev#17816)
  BUG: set tz on DTI from fixed format HDFStore (pandas-dev#17844)
  RLS: v0.21.0rc1
  Whatsnew cleanup (pandas-dev#17858)
  DEPR: Deprecate the convert parameter completely (pandas-dev#17831)
  ...
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug IO HDF5 read_hdf, HDFStore Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: roundtrip fidelity for a tz-aware DTI with a fixed format HDFStore
3 participants