BUG: Fix Index.putmask makes stack overflow with an invalid mask #18407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18407 +/- ##
==========================================
- Coverage 91.33% 91.29% -0.05%
==========================================
Files 163 163
Lines 49752 49754 +2
==========================================
- Hits 45443 45424 -19
- Misses 4309 4330 +21
Continue to review full report at Codecov.
|
jreback
added
Bug
Indexing
jreback
requested changes
Nov 22, 2017
pandas/core/indexes/base.py
Outdated
| # coerces to object | ||
| return self.astype(object).putmask(mask, value) | ||
| except (ValueError, TypeError) as err: | ||
| if self.dtype == np.dtype(object): |
There was a problem hiding this comment.
can you use is_object_dtype
pandas/core/indexes/base.py
Outdated
| except (ValueError, TypeError) as err: | ||
| if self.dtype == np.dtype(object): | ||
| raise err | ||
| else: |
There was a problem hiding this comment.
just use the return here, no else is needed
Licht-T
force-pushed
the
fix-index-putmask-stack-overflow
branch
from
683dab7 to
0b71ffe
Compare
|
@jreback Thanks! Fixed! |
jreback
approved these changes
Nov 25, 2017
|
lgtm. ping on green. |
|
thanks @Licht-T keep em coming! |
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 8, 2017
…das-dev#18407) (cherry picked from commit b69c1a2)
TomAugspurger
pushed a commit
that referenced
this pull request
Dec 11, 2017
) (cherry picked from commit b69c1a2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff