Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: ASV attrs_caching benchmark #18441

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Nov 23, 2017

  • Added np.random.seed(1234) in setup classes where random data is created xref BENCH: put in np.random.seed on vbenches #8144

  • Ran flake 8 and replaced star imports (with pep8 in mind, I think we should avoid from .pandas_vb_common import *)

$asv run -q -b ^attrs_caching
[ 33.33%] ··· Running attrs_caching.CacheReadonly.time_cache_readonly                                                                   9.12μs
[ 66.67%] ··· Running attrs_caching.DataFrameAttributes.time_get_index                                                                  14.5μs
[100.00%] ··· Running attrs_caching.DataFrameAttributes.time_set_index                                                                  27.3μs

@codecov
Copy link

codecov bot commented Nov 23, 2017

Codecov Report

Merging #18441 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18441      +/-   ##
==========================================
- Coverage   91.35%   91.34%   -0.02%     
==========================================
  Files         163      163              
  Lines       49691    49691              
==========================================
- Hits        45397    45388       -9     
- Misses       4294     4303       +9
Flag Coverage Δ
#multiple 89.14% <ø> (ø) ⬆️
#single 39.67% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fedc503...f5308d2. Read the comment docs.

@jreback jreback added the Benchmark Performance (ASV) benchmarks label Nov 23, 2017
@jreback jreback added this to the 0.22.0 milestone Nov 23, 2017
@jreback jreback merged commit 369df07 into pandas-dev:master Nov 23, 2017
@jreback
Copy link
Contributor

jreback commented Nov 23, 2017

thanks!

@mroeschke mroeschke deleted the asv_clean_attr_caching branch November 24, 2017 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants