-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parametrize offsets tests #18494
parametrize offsets tests #18494
Conversation
might be worthwhile moving Week, LastWeekOfMonth, SemiMonth to separate test file |
Very much on board. I'll also
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok trivial change. this patch is big enough!
pandas/tseries/offsets.py
Outdated
@apply_wraps | ||
def apply(self, other): | ||
n = self.n | ||
# First move to month offset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank lines before comments
pandas/tseries/offsets.py
Outdated
def apply(self, other): | ||
n = self.n | ||
dt_in = other | ||
# First move to month offset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
Seriously, yah. Glad I broke it out from the other one. |
Codecov Report
@@ Coverage Diff @@
## master #18494 +/- ##
==========================================
+ Coverage 91.3% 91.32% +0.02%
==========================================
Files 163 163
Lines 49781 49781
==========================================
+ Hits 45451 45463 +12
+ Misses 4330 4318 -12
Continue to review full report at Codecov.
|
thanks @jbrockmendel |
This began as part of #18489 and quickly became huge and tedious. Merits separating out and getting out of the way.
Move Year, Quarter, and Month offset test cases to a dedicated file
Implement pytest.mark.parametrize in very-nearly all the remaining places.