Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN/DOC: Interval and IntervalIndex classes #18585

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

jschendel
Copy link
Member

@jschendel jschendel commented Dec 1, 2017

Progress towards #16130

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Changes shouldn't impact the behavior of Interval or IntervalIndex:

  • Restructured the IntervalMixin class, as it was using legacy syntax for defining properties (see here)
  • Added docstrings to various Interval and IntervalIndex methods and attributes
  • Replaced % syntax with .format
  • Minor variable renaming for additional clarity, e.g. l -> lhs
    • My linter was complaining PEP 8 (E741): ambiguous variable name 'l'

Cleaning and docstring updates
@codecov
Copy link

codecov bot commented Dec 1, 2017

Codecov Report

Merging #18585 into master will decrease coverage by 0.04%.
The diff coverage is 80.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18585      +/-   ##
==========================================
- Coverage   91.44%    91.4%   -0.05%     
==========================================
  Files         157      157              
  Lines       51378    51379       +1     
==========================================
- Hits        46985    46964      -21     
- Misses       4393     4415      +22
Flag Coverage Δ
#multiple 89.27% <80.64%> (-0.03%) ⬇️
#single 40.57% <9.67%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/interval.py 93.05% <80.64%> (-0.17%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.44% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eedcf6...7907e68. Read the comment docs.

@jreback jreback added Docs Interval Interval data type labels Dec 1, 2017
@jreback jreback added this to the 0.22.0 milestone Dec 1, 2017
@jreback
Copy link
Contributor

jreback commented Dec 1, 2017

nice!

My linter was complaining PEP 8 (E741): ambiguous variable name 'l'

yeah this is in the newest flake8, we are currently pinning on travis, there is an issue about this, so thanks for changing!

@jreback jreback merged commit d74ac70 into pandas-dev:master Dec 1, 2017
@jschendel jschendel deleted the iv-doc-str branch December 1, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Interval Interval data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants