json_normalize: Make code more pythonic and avoid modification of meta if mutable #18610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18610 +/- ##
==========================================
- Coverage 91.46% 91.45% -0.02%
==========================================
Files 157 157
Lines 51439 51447 +8
==========================================
- Hits 47051 47049 -2
- Misses 4388 4398 +10
Continue to review full report at Codecov.
|
jreback
requested changes
Dec 3, 2017
| @@ -173,6 +173,20 @@ def test_meta_name_conflict(self): | |||
| for val in ['metafoo', 'metabar', 'foo', 'bar']: | |||
| assert val in result | |||
|
|
|||
| def test_meta_parameter_not_modified(self): | |||
| data = [{'foo': 'hello', | |||
There was a problem hiding this comment.
can you add the issue number here
|
@jreback is it OK now? Thanks. |
jreback
approved these changes
Dec 4, 2017
|
thanks! |
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 8, 2017
…a if mutable (pandas-dev#18610) (cherry picked from commit 2c903d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes itself json_normalize: Make code more pythonic and avoid modification of meta if mutable #18610
tests added / passed
passes
git diff master -u -- "*.py" | flake8 --diffwhatsnew entry
Update json_normalize to prevent modifying
metaparameter.Make the code more Pythonic too.