CLN: Remove io.data and io.wb #18612
Conversation
|
any remaining docs ? |
|
Didn't find anything that needed changing via GitHub search. |
|
I checked it. What about it? There's nothing out-of-date with those docs. |
|
let’s remove that section |
|
So just delete |
Codecov Report
@@ Coverage Diff @@
## master #18612 +/- ##
==========================================
+ Coverage 91.44% 91.45% +<.01%
==========================================
Files 157 155 -2
Lines 51449 51447 -2
==========================================
+ Hits 47048 47051 +3
+ Misses 4401 4396 -5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18612 +/- ##
==========================================
- Coverage 91.59% 91.58% -0.02%
==========================================
Files 155 153 -2
Lines 51255 51253 -2
==========================================
- Hits 46949 46939 -10
- Misses 4306 4314 +8
Continue to review full report at Codecov.
|
doc/source/whatsnew/v0.22.0.txt
Outdated
| @@ -136,6 +136,7 @@ Removal of prior version deprecations/changes | |||
| - ``pd.tseries.util.pivot_annual`` has been removed (deprecated since v0.19). Use ``pivot_table`` instead (:issue:`18370`) | |||
| - ``pd.tseries.util.isleapyear`` has been removed (deprecated since v0.19). Use ``.is_leap_year`` property in Datetime-likes instead (:issue:`18370`) | |||
| - ``pd.ordered_merge`` has been removed (deprecated since v0.19). Use ``pd.merge_ordered`` instead (:issue:`18459`) | |||
| - The ``pandas.io.wb`` and ``pandas.io.data`` modules have been removed (:issue:`13735`) | |||
There was a problem hiding this comment.
I would phrase this a bit differently, as now it seems the modules were still there, while there was just a shim that only raised an error.
There was a problem hiding this comment.
What exactly would you say? It's a little tricky to describe the difference between now and then with regards to this change given that there was this ImportError phase. To be more precise about what changed is perhaps more relevant for a developer than the everyday user to be honest.
There was a problem hiding this comment.
Well, the exact thing that changes is actually only the message of the import error, so maybe not worth to list at all?
There was a problem hiding this comment.
Perhaps not, actually. @jreback , what do you think?
There was a problem hiding this comment.
these are really stub modules, which you could say.
|
remove remote_data.rst entirely as well. |
Deprecated in 0.17.0. xref pandas-devgh-13735.
gfyoung
force-pushed
the
remove-wb-data
branch
from
8541a0e to
46cf498
Compare
|
thanks! |
Deprecated in 0.17.0.
xref #13735.