Spellcheck

[tommyod]

This PR is a continuation of my read-through of the docs, the earlier PRs are #18941, #18973 and #18948.

The changes included in this PR include

• Changed spelling of "python" to "Python" for consistency, same with "numpy" to "NumPy". This change was made globally, i.e. for most documents in /docs/source/.
• A review of groupby.rst and missing_data.rst
  • Added punctuation where missing.
  • Added more function references (i.e. :meth:...) where appropriate.
  • Rewrote a few sentences.

Feedback is very welcome.

[jreback]

Changed spelling of "python" to "Python" for consistency, same with "numpy" to "NumPy". This change was made globally, i.e. for most documents in /docs/source/.

can you add a lint rule for this (and other things that we want to check globally)
in ci/lint.sh

[jreback]

also can you add a note in the whats new about documentation edits (there is a section) and include these PR#'s ?
and a similar note for #18966

[codecov]

Codecov Report

Merging #19017 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19017   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         150      150           
  Lines       48942    48942           
=======================================
  Hits        44816    44816           
  Misses       4126     4126

Flag	Coverage Δ
#multiple	89.93% <ø> (ø)	⬆️
#single	41.75% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04beec7...277c1b8. Read the comment docs.

[tommyod]

@jreback I've added a reference to this and earlier PRs in whatsnew/v0.23.0.txt. I don't know how to make the linting rule, since for instance numpy should be replaced with NumPy in writte documentation, but not in the accompanying code. Not sure how to enforce this.

[jreback]

rebase and push again, fixed some hanging by Travis CI

[jreback]

small comments. can you add a rule in lint.sh?

[jreback]

can you make this 3.6

[jreback]

or rather say Python 3

[jreback]

can you double-backticks Series/DataFrame when you see

[tommyod]

@jreback - I've addressed the review, rebased and pushed. I could not figure out good logic for a rule in lint.sh, will come back to this in the future if I figure it out.

[WillAyd]

@tommyod the grep command below could be a starter for you. This will find any instance of numpy but subsequently exclude it if the line contains from or import

It could miss some lines like # need to import foo from numpy but should realistically catch most issues

grep -R --include="*.py" --include="*.pyx" --include="*.rst" "numpy" $path | grep -Ev "from|import"

[jreback]

thanks @tommyod

yeah a rule similar to

grep -R --include="*.py" --include="*.pyx" --include="*.rst" "numpy" doc/ pandas/ | grep -Ev "from|import|_numpy_|\/numpy\/"

is close, though picking up extra things so prob have to add a bit to it

would take as a followup