Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove the Panel4D and PanelND classes #19059

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jan 3, 2018

Deprecated back in v0.19.0

xref #13147

@gfyoung gfyoung added Clean Deprecate Functionality to remove in pandas labels Jan 3, 2018
@gfyoung gfyoung added this to the 0.23.0 milestone Jan 3, 2018
@gfyoung gfyoung force-pushed the panel-depr-remove branch from 4eba070 to b2b478f Compare January 3, 2018 18:03
@codecov
Copy link

codecov bot commented Jan 3, 2018

Codecov Report

Merging #19059 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19059      +/-   ##
==========================================
- Coverage   91.56%    91.5%   -0.07%     
==========================================
  Files         150      148       -2     
  Lines       48942    48852      -90     
==========================================
- Hits        44816    44701     -115     
- Misses       4126     4151      +25
Flag Coverage Δ
#multiple 89.87% <100%> (-0.06%) ⬇️
#single 41.64% <66.66%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/core/panel.py 96.84% <ø> (-0.01%) ⬇️
pandas/util/testing.py 84.45% <ø> (-0.3%) ⬇️
pandas/core/api.py 100% <ø> (ø) ⬆️
pandas/core/generic.py 95.9% <100%> (-0.05%) ⬇️
pandas/core/dtypes/generic.py 100% <100%> (ø) ⬆️
pandas/io/pytables.py 92.45% <100%> (-0.4%) ⬇️
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️
pandas/core/indexing.py 92.62% <0%> (-0.19%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6552718...b2b478f. Read the comment docs.

@jreback jreback merged commit 61ed3e5 into pandas-dev:master Jan 3, 2018
@jreback
Copy link
Contributor

jreback commented Jan 3, 2018

love it! thanks! (and am NOT sad that you blew away a lot of my original code), lol.

@gfyoung
Copy link
Member Author

gfyoung commented Jan 4, 2018

@jreback : If you have any emotional attachment to that code, I'd be more than happy to create a separate branch where it lives on 😄

@jreback
Copy link
Contributor

jreback commented Jan 4, 2018

hahah
i still prob have the original branch
i don’t usually delete them (so i have thousands :)

@gfyoung
Copy link
Member Author

gfyoung commented Jan 4, 2018

i still prob have the original branch
i don’t usually delete them (so i have thousands :)

Awesome, glad we resolved that (non-)issue :)

jreback added a commit to jreback/pandas that referenced this pull request Jan 4, 2018
@gfyoung gfyoung deleted the panel-depr-remove branch January 4, 2018 05:15
jreback added a commit that referenced this pull request Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants