Ignore warnings when reading pickle files #19580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silences a warning from our tests about
```
pandas/tests/io/test_common.py::TestCommonIOCapabilities::()::test_read_fspath_all[reader10-os-/home/travis/build/pandas-dev/pandas/pandas/tests/io/data/categorical_0_14_1.pickle]
/home/travis/build/pandas-dev/pandas/pandas/io/pickle.py:99: FutureWarning: 'pandas.core' is private. Use 'pandas.Categorical'
return read_wrapper(lambda f: pkl.load(f))
```
TomAugspurger
added
Testing
|
we. an move up our pickle compat as well maybe make a new issue for this |
|
… On Wed, Feb 7, 2018 at 11:46 AM, Jeff Reback ***@***.***> wrote:
we. an move up our pickle compat as well
i think we r at 0.13 maybe move to 0.17
maybe make a new issue for this
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19580 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIh8lxoVwV9aTbNjTTZV3W53DqsqKks5tSeF1gaJpZM4R9HUX>
.
|
jreback
requested changes
Feb 8, 2018
pandas/io/pickle.py
Outdated
| @@ -96,7 +97,8 @@ def try_read(path, encoding=None): | |||
| # cpickle | |||
| # GH 6899 | |||
| try: | |||
| return read_wrapper(lambda f: pkl.load(f)) | |||
| with warnings.simplefilter('ignore'): | |||
Codecov Report
@@ Coverage Diff @@
## master #19580 +/- ##
==========================================
+ Coverage 91.62% 91.62% +<.01%
==========================================
Files 150 150
Lines 48773 48790 +17
==========================================
+ Hits 44687 44703 +16
- Misses 4086 4087 +1
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 8, 2018
pandas/io/pickle.py
Outdated
| @@ -96,7 +97,9 @@ def try_read(path, encoding=None): | |||
| # cpickle | |||
| # GH 6899 | |||
| try: | |||
| return read_wrapper(lambda f: pkl.load(f)) | |||
| with warnings.catch_warnings(): | |||
| warnings.simplefilter('ignore') | |||
There was a problem hiding this comment.
you don't need the simple filter
warnings.catch_warnings(record=True)
There was a problem hiding this comment.
Oh, I didn't know that.
jreback
approved these changes
Feb 9, 2018
|
thanks! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silences a warning from our tests about