-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC/BLD: unpin sphinx to use sphinx 1.7 #19687
DOC/BLD: unpin sphinx to use sphinx 1.7 #19687
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19687 +/- ##
==========================================
+ Coverage 91.6% 91.66% +0.05%
==========================================
Files 150 150
Lines 48908 48938 +30
==========================================
+ Hits 44804 44860 +56
+ Misses 4104 4078 -26
Continue to review full report at Codecov.
|
loooks like the build timedout |
Yep, but it is still using sphinx 1.6.6, so therefore that was to be expected. |
i think we also have conda-forge channel on the doc build (or rather u can specify it if u need) |
Last commit seems to work! No failure, no time-out |
I think it would be good (in another PR) to update our vendored versions of IPython.sphinxext and numpydoc to their latest versions, so once they are released, it will be easier to remove them. |
@jorisvandenbossche I think the main channel has been updated to include sphinx 1.7 |
OK, thanks for noticing. Updated the PR. If it builds, this should be good to go. |
FYI I won't generally merge doc related PR's (for doc building type things), unless you ping and say ok |
It was just a general note, not necessarily meant to say that you should merge this :) |
xref #18147, closes #16705
Sphinx 1.7 is released, so let's try out if we can now remove the pinning of sphinx to 1.5.x