Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/BLD: unpin sphinx to use sphinx 1.7 #19687

Merged

Conversation

jorisvandenbossche
Copy link
Member

xref #18147, closes #16705

Sphinx 1.7 is released, so let's try out if we can now remove the pinning of sphinx to 1.5.x

@codecov
Copy link

codecov bot commented Feb 14, 2018

Codecov Report

Merging #19687 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19687      +/-   ##
==========================================
+ Coverage    91.6%   91.66%   +0.05%     
==========================================
  Files         150      150              
  Lines       48908    48938      +30     
==========================================
+ Hits        44804    44860      +56     
+ Misses       4104     4078      -26
Flag Coverage Δ
#multiple 90.04% <ø> (+0.05%) ⬆️
#single 41.81% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️
pandas/core/dtypes/cast.py 87.68% <0%> (-0.3%) ⬇️
pandas/core/dtypes/dtypes.py 95.9% <0%> (-0.19%) ⬇️
pandas/core/indexing.py 93.02% <0%> (-0.1%) ⬇️
pandas/core/frame.py 97.18% <0%> (-0.06%) ⬇️
pandas/core/generic.py 95.88% <0%> (-0.05%) ⬇️
pandas/core/series.py 94.41% <0%> (-0.05%) ⬇️
pandas/core/indexes/range.py 95.7% <0%> (-0.04%) ⬇️
pandas/core/apply.py 96.74% <0%> (-0.04%) ⬇️
pandas/core/dtypes/generic.py 100% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc4ef9...56770e4. Read the comment docs.

@jreback jreback modified the milestone: 0.23.0 Feb 14, 2018
@jreback
Copy link
Contributor

jreback commented Feb 14, 2018

loooks like the build timedout

@jorisvandenbossche
Copy link
Member Author

Yep, but it is still using sphinx 1.6.6, so therefore that was to be expected.
Apparently it's not yet on the defaults channel (it's on conda-forge, but I assume we just use defaults?)

@jreback
Copy link
Contributor

jreback commented Feb 14, 2018

i think we also have conda-forge channel on the doc build (or rather u can specify it if u need)
but that’s in the .sh parts

@jorisvandenbossche
Copy link
Member Author

Last commit seems to work! No failure, no time-out

@jorisvandenbossche
Copy link
Member Author

I think it would be good (in another PR) to update our vendored versions of IPython.sphinxext and numpydoc to their latest versions, so once they are released, it will be easier to remove them.

@TomAugspurger
Copy link
Contributor

@jorisvandenbossche I think the main channel has been updated to include sphinx 1.7

@jorisvandenbossche
Copy link
Member Author

OK, thanks for noticing. Updated the PR. If it builds, this should be good to go.

@jreback
Copy link
Contributor

jreback commented Feb 25, 2018

FYI I won't generally merge doc related PR's (for doc building type things), unless you ping and say ok

@jorisvandenbossche
Copy link
Member Author

It was just a general note, not necessarily meant to say that you should merge this :)
Anyway, it is building! (and not timing out)

@jorisvandenbossche jorisvandenbossche merged commit 4ddbcb8 into pandas-dev:master Feb 26, 2018
@jorisvandenbossche jorisvandenbossche deleted the doc-sphinx-1.7 branch February 26, 2018 08:46
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: fix API docs generation with sphinx 1.6
3 participants