DEPR: remove v018 resample compatibilitiy #20782
Conversation
jreback
added
Resample
Codecov Report
@@ Coverage Diff @@
## master #20782 +/- ##
==========================================
- Coverage 91.84% 91.78% -0.07%
==========================================
Files 153 153
Lines 49305 49247 -58
==========================================
- Hits 45286 45203 -83
- Misses 4019 4044 +25
Continue to review full report at Codecov.
|
|
@jorisvandenbossche @TomAugspurger if any comments |
|
@jorisvandenbossche I don't see a note from you. Perhaps it wasn't submitted? |
| @@ -62,20 +62,6 @@ class Resampler(_GroupBy): | |||
| _attributes = ['freq', 'axis', 'closed', 'label', 'convention', | |||
| 'loffset', 'base', 'kind'] | |||
|
|
|||
| # API compat of allowed attributes | |||
| _deprecated_valids = _attributes + ['__doc__', '_cache', '_attributes', | |||
| 'binner', 'grouper', 'groupby', | |||
There was a problem hiding this comment.
whoops, didn't push the button probably :-)
My question was about the above _deprecated_valids: what was the purpose of them? At least before, those attributes did not raise any warning.
There was a problem hiding this comment.
But you can probably ignore my comment, those attributes are "hided" from tab completion anyway, and didn't change for the rest. I suppose this was here before to prevent raising any warning on them?
There was a problem hiding this comment.
yes, this was gymnastics to make all of this work
closes #20554