Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't raise warning on merging int and float with nan #21011

Merged
merged 1 commit into from
May 11, 2018
Merged

Don't raise warning on merging int and float with nan #21011

merged 1 commit into from
May 11, 2018

Conversation

jorisvandenbossche
Copy link
Member

Closes #20998

@jorisvandenbossche jorisvandenbossche added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label May 11, 2018
@jorisvandenbossche jorisvandenbossche added this to the 0.23.0 milestone May 11, 2018
@codecov
Copy link

codecov bot commented May 11, 2018 •
edited
Loading

Codecov Report

Merging #21011 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21011   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files         153      153           
  Lines       49491    49491           
=======================================
  Hits        45446    45446           
  Misses       4045     4045
Flag Coverage Δ
#multiple 90.22% <100%> (ø) ⬆️
#single 41.85% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/merge.py 94.25% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a0ca1...2c24590. Read the comment docs.

@jreback jreback merged commit 0e00151 into pandas-dev:master May 11, 2018
@jreback
Copy link
Contributor

jreback commented May 11, 2018

thanks @jorisvandenbossche

topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 13, 2018
@jorisvandenbossche
Don't raise warning on merging int and float with nan (pandas-dev#21011)
34b0cc6
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 13, 2018
@jorisvandenbossche
Don't raise warning on merging int and float with nan (pandas-dev#21011)
75e19cc
@jorisvandenbossche jorisvandenbossche deleted the merge-nan-no-warning branch May 24, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @jreback